Issue 990343002: Add an optional 'typeParameters' to Element.

Issue 990343002: Add an optional 'typeParameters' to Element. (Closed)

Created:
5 years, 9 months ago by scheglov

Modified:
5 years, 9 months ago

Reviewers:
Brian Wilkerson

CC:
reviews_dartlang.org, ricow1

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Target Ref:
refs/remotes/git-svn

Visibility:
Public.

More Reviews

Description

Add an optional 'typeParameters' to Element. Also use it in Editor, e.g. in Outline. R=brianwilkerson@google.com BUG= Committed: https://code.google.com/p/dart/source/detail?r=44349

Patch Set 2 : Update version. #

Created: 5 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+176 lines, -62 lines)			Patch
M	editor/tools/plugins/com.google.dart.server/src/com/google/dart/server/generated/types/Element.java	View		7 chunks	+27 lines, -4 lines	0 comments	Download
M	editor/tools/plugins/com.google.dart.tools.ui/src/com/google/dart/tools/ui/internal/text/editor/ElementLabelProvider_NEW.java	View		1 chunk	+5 lines, -0 lines	0 comments	Download
M	pkg/analysis_server/doc/api.html	View	1	2 chunks	+7 lines, -1 line	0 comments	Download
M	pkg/analysis_server/lib/src/analysis_server.dart	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	pkg/analysis_server/lib/src/computer/computer_outline.dart	View		3 chunks	+29 lines, -20 lines	0 comments	Download
M	pkg/analysis_server/lib/src/generated_protocol.dart	View		6 chunks	+19 lines, -3 lines	0 comments	Download
M	pkg/analysis_server/lib/src/protocol_server.dart	View		3 chunks	+15 lines, -0 lines	0 comments	Download
M	pkg/analysis_server/test/analysis/notification_outline_test.dart	View		10 chunks	+27 lines, -12 lines	0 comments	Download
M	pkg/analysis_server/test/integration/protocol_matchers.dart	View		2 chunks	+3 lines, -1 line	0 comments	Download
M	pkg/analysis_server/test/protocol_server_test.dart	View		3 chunks	+35 lines, -19 lines	0 comments	Download
M	pkg/analysis_server/tool/spec/spec_input.html	View	1	2 chunks	+8 lines, -1 line	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Brian Wilkerson

LGTM https://codereview.chromium.org/990343002/diff/1/pkg/analysis_server/tool/spec/spec_input.html File pkg/analysis_server/tool/spec/spec_input.html (right): https://codereview.chromium.org/990343002/diff/1/pkg/analysis_server/tool/spec/spec_input.html#newcode9 pkg/analysis_server/tool/spec/spec_input.html:9: <h1 style="color:#999999">Version <version>1.3.0</version></h1> I believe that we need ...

5 years, 9 months ago (2015-03-09 21:53:44 UTC) #2

scheglov

Committed patchset #2 (id:20001) manually as 44349 (presubmit successful).

5 years, 9 months ago (2015-03-09 22:02:58 UTC) #3

scheglov

5 years, 9 months ago (2015-03-09 22:19:41 UTC) #4

Message was sent while issue was closed.

https://codereview.chromium.org/990343002/diff/1/pkg/analysis_server/tool/spe...
File pkg/analysis_server/tool/spec/spec_input.html (right):

https://codereview.chromium.org/990343002/diff/1/pkg/analysis_server/tool/spe...
pkg/analysis_server/tool/spec/spec_input.html:9: <h1
style="color:#999999">Version <version>1.3.0</version></h1>
On 2015/03/09 21:53:44, Brian Wilkerson wrote:
> I believe that we need to change the version number, both here and in
> AnalysisServer.VERSION to 1.4.0.

Done.

Expand Messages | Collapse Messages