Issue 989633003: Fix await x++

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 989633003: Fix await x++ (Closed)

Created:
5 years, 9 months ago by hausner

Modified:
5 years, 9 months ago

Reviewers:
regis, Ivan Posva

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

Fix await x++ Fixes compiler crash bug 22634 Simplify transformation of await expressions. Do not allocate unnecessary temporary variables. Await LetNode temporary expressions still does not work properly since the temporary values are only saved on the stack by the back-end. Thus, a[await f()]++ still does not work after this change. R=iposva@google.com Committed: https://code.google.com/p/dart/source/detail?r=44337

Patch Set 1 #

Patch Set 2 : #

Created: 5 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+65 lines, -18 lines)			Patch
	M	runtime/vm/ast_transformer.cc	View	1	2 chunks	+18 lines, -18 lines	0 comments	Download
	A	tests/language/await_postfix_expr_test.dart	View		1 chunk	+47 lines, -0 lines	0 comments	Download

Messages

Total messages: 4 (1 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

hausner

5 years, 9 months ago (2015-03-09 19:17:31 UTC) #4

Message was sent while issue was closed.

Committed patchset #2 (id:20001) manually as r44337 (presubmit successful).

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages