Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(161)

Issue 989503002: Fix dart2js async error handling of finallies nested in finallies. (Closed)

Created:
5 years, 9 months ago by sigurdm
Modified:
5 years, 9 months ago
Reviewers:
floitsch
CC:
reviews_dartlang.org, Lasse Reichstein Nielsen
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Fix dart2js async error handling of finallies nested in finallies. BUG= R=floitsch@google.com Committed: https://code.google.com/p/dart/source/detail?r=44287

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+42 lines, -4 lines) Patch
M pkg/compiler/lib/src/js/rewrite_async.dart View 3 chunks +6 lines, -4 lines 0 comments Download
M tests/language/async_throw_in_catch_test.dart View 2 chunks +36 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
sigurdm
5 years, 9 months ago (2015-03-06 09:22:12 UTC) #2
floitsch
LGTM.
5 years, 9 months ago (2015-03-06 12:27:24 UTC) #3
sigurdm
5 years, 9 months ago (2015-03-06 12:48:41 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as 44287 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698