Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(58)

Issue 989393002: Wrap dart:io exception in getChildren(), implement for the memory FS. (Closed)

Created:
5 years, 9 months ago by scheglov
Modified:
5 years, 9 months ago
Reviewers:
Brian Wilkerson
CC:
reviews_dartlang.org
Target Ref:
refs/remotes/git-svn
Visibility:
Public.

Description

Wrap dart:io exception in getChildren(), implement for the memory FS. ...for consistency. Plus tests. R=brianwilkerson@google.com BUG= Committed: https://code.google.com/p/dart/source/detail?r=44358

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+88 lines, -63 lines) Patch
M pkg/analyzer/lib/file_system/memory_file_system.dart View 3 chunks +14 lines, -11 lines 0 comments Download
M pkg/analyzer/lib/file_system/physical_file_system.dart View 2 chunks +16 lines, -12 lines 0 comments Download
M pkg/analyzer/test/file_system/memory_file_system_test.dart View 1 chunk +29 lines, -20 lines 0 comments Download
M pkg/analyzer/test/file_system/physical_resource_provider_test.dart View 1 chunk +29 lines, -20 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
scheglov
5 years, 9 months ago (2015-03-10 03:05:24 UTC) #1
Brian Wilkerson
LGTM
5 years, 9 months ago (2015-03-10 04:04:42 UTC) #2
scheglov
5 years, 9 months ago (2015-03-10 04:31:08 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as 44358 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698