Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(512)

Issue 988903003: Fix finalization of cyclic mixin types (issue 22666). (Closed)

Created:
5 years, 9 months ago by regis
Modified:
5 years, 9 months ago
Reviewers:
siva
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Visibility:
Public.

Description

Fix finalization of cyclic mixin types (issue 22666). Add regression test. R=asiva@google.com Committed: https://code.google.com/p/dart/source/detail?r=44306

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+76 lines, -19 lines) Patch
M runtime/vm/object.h View 6 chunks +18 lines, -5 lines 0 comments Download
M runtime/vm/object.cc View 8 chunks +49 lines, -14 lines 0 comments Download
A tests/language/regress_22666_test.dart View 1 chunk +9 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
regis
5 years, 9 months ago (2015-03-06 23:32:59 UTC) #2
siva
lgtm
5 years, 9 months ago (2015-03-07 00:12:37 UTC) #3
regis
5 years, 9 months ago (2015-03-07 00:25:32 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as r44306 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698