Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(115)

Issue 988743002: Fix incorrect kNumTemps for BinaryUint32OpInstr on x64 (Closed)

Created:
5 years, 9 months ago by Vyacheslav Egorov (Google)
Modified:
5 years, 9 months ago
Reviewers:
Cutch
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Target Ref:
refs/remotes/git-svn
Visibility:
Public.

Description

Fix incorrect kNumTemps for BinaryUint32OpInstr on x64 R=johnmccutchan@google.com BUG=http://dartbug.com/22693 Committed: https://code.google.com/p/dart/source/detail?r=44296

Patch Set 1 #

Patch Set 2 : Add test #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -14 lines) Patch
M runtime/vm/intermediate_language_x64.cc View 1 chunk +1 line, -1 line 0 comments Download
A + tests/language/vm/regress_22693_vm_test.dart View 1 1 chunk +4 lines, -13 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Vyacheslav Egorov (Google)
5 years, 9 months ago (2015-03-06 16:46:07 UTC) #1
Cutch
5 years, 9 months ago (2015-03-06 17:51:12 UTC) #2
Cutch
lgtm
5 years, 9 months ago (2015-03-06 17:51:13 UTC) #3
Vyacheslav Egorov (Google)
5 years, 9 months ago (2015-03-06 17:54:19 UTC) #4
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as 44296 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698