Don't send notifications for disposed contexts.

Don't send notifications for disposed contexts.

This ensures that once analysis.flushResults is implemented, we won't
accidentally send a stale notification for a file after flushing its
results.

R=scheglov@google.com

Committed: https://code.google.com/p/dart/source/detail?r=44275

[Paul Berry, 2015-03-05 23:47:54]

paulberry@google.com changed reviewers:
+ jwren@google.com, scheglov@google.com

[scheglov, 2015-03-06 00:37:23]

LGTM

https://codereview.chromium.org/988593002/diff/1/pkg/analysis_server/lib/src/...
File pkg/analysis_server/lib/src/operation/operation_queue.dart (right):

https://codereview.chromium.org/988593002/diff/1/pkg/analysis_server/lib/src/...
pkg/analysis_server/lib/src/operation/operation_queue.dart:61: (ServerOperation
operation) => operation.context == context);
IMHO if there is a line break, the function is too complex to use  the
expression body style.

https://codereview.chromium.org/988593002/diff/1/pkg/analysis_server/test/ope...
File pkg/analysis_server/test/operation/operation_queue_test.dart (right):

https://codereview.chromium.org/988593002/diff/1/pkg/analysis_server/test/ope...
pkg/analysis_server/test/operation/operation_queue_test.dart:166: class
_ContextOperationMock extends TypedMock implements ServerOperation {
We could merge this class with _ServerOperationMock, and make "context" an
optional parameter.

[Paul Berry, 2015-03-06 01:11:09]

https://codereview.chromium.org/988593002/diff/1/pkg/analysis_server/lib/src/...
File pkg/analysis_server/lib/src/operation/operation_queue.dart (right):

https://codereview.chromium.org/988593002/diff/1/pkg/analysis_server/lib/src/...
pkg/analysis_server/lib/src/operation/operation_queue.dart:61: (ServerOperation
operation) => operation.context == context);
On 2015/03/06 00:37:23, scheglov wrote:
> IMHO if there is a line break, the function is too complex to use  the
> expression body style.

Hmm, I'm not sure if I agree with the general principle, but it was pretty easy
to squeeze down to one line by removing the type annotation.  Done :)

https://codereview.chromium.org/988593002/diff/1/pkg/analysis_server/test/ope...
File pkg/analysis_server/test/operation/operation_queue_test.dart (right):

https://codereview.chromium.org/988593002/diff/1/pkg/analysis_server/test/ope...
pkg/analysis_server/test/operation/operation_queue_test.dart:166: class
_ContextOperationMock extends TypedMock implements ServerOperation {
On 2015/03/06 00:37:23, scheglov wrote:
> We could merge this class with _ServerOperationMock, and make "context" an
> optional parameter.

Done.

[Paul Berry, 2015-03-06 01:17:44]

Committed patchset #1 (id:1) manually as 44275 (presubmit successful).