Issue 988243005: Fix element_types_constructors split out tests

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 988243005: Fix element_types_constructors split out tests (Closed)

Created:
5 years, 9 months ago by Alan Knight

Modified:
5 years, 9 months ago

Reviewers:
terry, Bill Hesse

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Target Ref:
refs/remotes/git-svn

Visibility:
Public.

Fix element_types_constructors split out tests BUG= Committed: https://code.google.com/p/dart/source/detail?r=44332

Created: 5 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+103 lines, -82 lines)			Patch
M	tests/html/element_types_constructors1_test.dart	View	1 chunk	+21 lines, -19 lines	0 comments	Download
M	tests/html/element_types_constructors2_test.dart	View	1 chunk	+18 lines, -16 lines	0 comments	Download
M	tests/html/element_types_constructors3_test.dart	View	1 chunk	+20 lines, -18 lines	0 comments	Download
M	tests/html/element_types_constructors4_test.dart	View	1 chunk	+15 lines, -13 lines	0 comments	Download
M	tests/html/element_types_constructors5_test.dart	View	1 chunk	+16 lines, -14 lines	0 comments	Download
M	tests/html/element_types_constructors6_test.dart	View	2 chunks	+13 lines, -2 lines	0 comments	Download

Total messages: 3 (1 generated)

Alan Knight

It appears that for tests generated by calling check like that, they aren't run unless ...

5 years, 9 months ago (2015-03-09 17:54:01 UTC) #2

Alan Knight

5 years, 9 months ago (2015-03-09 17:54:24 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as 44332 (presubmit successful).