Issue 98773002: Rewrite file-system-watcher to better handle the different system APIs.

Issue 98773002: Rewrite file-system-watcher to better handle the different system APIs. (Closed)

Created:
7 years ago by Anders Johnsen

Modified:
7 years ago

Reviewers:
Søren Gjesse

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Rewrite file-system-watcher to better handle the different system APIs. BUG=http://code.google.com/p/dart/issues/detail?id=14941 R=sgjesse@google.com Committed: https://code.google.com/p/dart/source/detail?r=30848

Patch Set 1 #

Patch Set 2 : Add Windows support. #

Patch Set 3 : Clean up linux impl. #

Patch Set 4 : Update Mac OS as well #

Patch Set 5 : Fix a few issues #

Patch Set 6 : Last few fixes found by tests #

Total comments: 7

Patch Set 7 : Android impl and doc fix. #

Created: 7 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+442 lines, -216 lines)			Patch
M	pkg/pkg.status	View	1 2 3 4 5 6	1 chunk	+1 line, -1 line	0 comments	Download
M	runtime/bin/builtin_natives.cc	View	1 2 3	1 chunk	+5 lines, -2 lines	0 comments	Download
M	runtime/bin/file_patch.dart	View	1 2 3 4 5 6	3 chunks	+231 lines, -54 lines	0 comments	Download
M	runtime/bin/file_system_watcher.h	View		1 chunk	+9 lines, -4 lines	0 comments	Download
M	runtime/bin/file_system_watcher.cc	View	1 2 3	1 chunk	+26 lines, -23 lines	0 comments	Download
M	runtime/bin/file_system_watcher_android.cc	View	1 2 3 4 5 6	2 chunks	+50 lines, -35 lines	0 comments	Download
M	runtime/bin/file_system_watcher_linux.cc	View	1 2	2 chunks	+48 lines, -33 lines	0 comments	Download
M	runtime/bin/file_system_watcher_macos.cc	View	1 2 3	9 chunks	+39 lines, -47 lines	0 comments	Download
M	runtime/bin/file_system_watcher_win.cc	View	1	4 chunks	+24 lines, -8 lines	0 comments	Download
M	sdk/lib/_internal/lib/io_patch.dart	View	1 2 3	1 chunk	+3 lines, -2 lines	0 comments	Download
M	sdk/lib/io/file_system_entity.dart	View	1 2 3	2 chunks	+6 lines, -7 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Søren Gjesse

lgtm https://codereview.chromium.org/98773002/diff/100001/runtime/bin/file_patch.dart File runtime/bin/file_patch.dart (right): https://codereview.chromium.org/98773002/diff/100001/runtime/bin/file_patch.dart#newcode137 runtime/bin/file_patch.dart:137: Please add a comment here on the lifecycle ...

7 years ago (2013-12-03 14:42:18 UTC) #2

Anders Johnsen

https://codereview.chromium.org/98773002/diff/100001/runtime/bin/file_patch.dart File runtime/bin/file_patch.dart (right): https://codereview.chromium.org/98773002/diff/100001/runtime/bin/file_patch.dart#newcode137 runtime/bin/file_patch.dart:137: On 2013/12/03 14:42:19, Søren Gjesse wrote: > Please add ...

7 years ago (2013-12-04 10:30:52 UTC) #3

Anders Johnsen

7 years ago (2013-12-04 10:35:13 UTC) #4

Message was sent while issue was closed.

Committed patchset #7 manually as r30848 (presubmit successful).

Expand Messages | Collapse Messages