Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(346)

Issue 987173002: Quick Fix for returning Future from 'async' functions. (Closed)

Created:
5 years, 9 months ago by scheglov
Modified:
5 years, 9 months ago
Reviewers:
Brian Wilkerson
CC:
reviews_dartlang.org
Target Ref:
refs/remotes/git-svn
Visibility:
Public.

Description

Quick Fix for returning Future from 'async' functions. R=brianwilkerson@google.com BUG= Committed: https://code.google.com/p/dart/source/detail?r=44348

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+90 lines, -1 line) Patch
M pkg/analysis_server/lib/src/services/correction/fix.dart View 1 chunk +3 lines, -0 lines 0 comments Download
M pkg/analysis_server/lib/src/services/correction/fix_internal.dart View 3 chunks +22 lines, -1 line 0 comments Download
M pkg/analysis_server/test/services/correction/fix_test.dart View 1 chunk +65 lines, -0 lines 2 comments Download

Messages

Total messages: 4 (0 generated)
scheglov
5 years, 9 months ago (2015-03-09 20:31:31 UTC) #1
Brian Wilkerson
LGTM https://codereview.chromium.org/987173002/diff/1/pkg/analysis_server/test/services/correction/fix_test.dart File pkg/analysis_server/test/services/correction/fix_test.dart (right): https://codereview.chromium.org/987173002/diff/1/pkg/analysis_server/test/services/correction/fix_test.dart#newcode1788 pkg/analysis_server/test/services/correction/fix_test.dart:1788: void test_illegalAsyncReturnType_void() { Perhaps a test case containing: ...
5 years, 9 months ago (2015-03-09 21:05:35 UTC) #2
scheglov
https://codereview.chromium.org/987173002/diff/1/pkg/analysis_server/test/services/correction/fix_test.dart File pkg/analysis_server/test/services/correction/fix_test.dart (right): https://codereview.chromium.org/987173002/diff/1/pkg/analysis_server/test/services/correction/fix_test.dart#newcode1788 pkg/analysis_server/test/services/correction/fix_test.dart:1788: void test_illegalAsyncReturnType_void() { On 2015/03/09 21:05:35, Brian Wilkerson wrote: ...
5 years, 9 months ago (2015-03-09 21:34:37 UTC) #3
scheglov
5 years, 9 months ago (2015-03-09 21:35:39 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as 44348 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698