Fix for dartbug.com/22656- analysis.flushedResults implementation.

Fix for dartbug.com/22656- analysis.flushedResults implementation.

R=brianwilkerson@google.com, paulberry@google.com

Committed: https://code.google.com/p/dart/source/detail?r=44373

[jwren, 2015-03-09 18:45:12]

jwren@google.com changed reviewers:
+ brianwilkerson@google.com, paulberry@google.com

[Brian Wilkerson, 2015-03-09 18:56:09]

LGTM

https://codereview.chromium.org/987143002/diff/1/pkg/analysis_server/lib/src/...
File pkg/analysis_server/lib/src/context_manager.dart (right):

https://codereview.chromium.org/987143002/diff/1/pkg/analysis_server/lib/src/...
pkg/analysis_server/lib/src/context_manager.dart:131: if (context != contextN) {
Can we move the 'for' loop inside the 'if'? Doing so will reduce the amount of
work we do.

[jwren, 2015-03-09 19:55:14]

https://codereview.chromium.org/987143002/diff/1/pkg/analysis_server/lib/src/...
File pkg/analysis_server/lib/src/context_manager.dart (right):

https://codereview.chromium.org/987143002/diff/1/pkg/analysis_server/lib/src/...
pkg/analysis_server/lib/src/context_manager.dart:131: if (context != contextN) {
Fixed

[Paul Berry, 2015-03-09 22:40:10]

lgtm

https://codereview.chromium.org/987143002/diff/20001/pkg/analysis_server/lib/...
File pkg/analysis_server/lib/src/context_manager.dart (right):

https://codereview.chromium.org/987143002/diff/20001/pkg/analysis_server/lib/...
pkg/analysis_server/lib/src/context_manager.dart:132:
flushedFiles.remove(source.fullName);
This is an O(n^2) algorithm, where n is the number of files in a context (which
could get quite large).  Consider making flushedFiles a HashSet<String> instead.

[jwren, 2015-03-10 14:52:41]

https://codereview.chromium.org/987143002/diff/20001/pkg/analysis_server/lib/...
File pkg/analysis_server/lib/src/context_manager.dart (right):

https://codereview.chromium.org/987143002/diff/20001/pkg/analysis_server/lib/...
pkg/analysis_server/lib/src/context_manager.dart:132:
flushedFiles.remove(source.fullName);
On 2015/03/09 22:40:10, Paul Berry wrote:
> This is an O(n^2) algorithm, where n is the number of files in a context
(which
> could get quite large).  Consider making flushedFiles a HashSet<String>
instead.

Done.  Of course, after all of our conversations around more performant ways we
may want to do this in the future, my bit was apparently off.

[jwren, 2015-03-10 14:54:10]

Committed patchset #3 (id:40001) manually as 44373 (presubmit successful).