Add a utility function to parse annotations in a test file.

Add a utility function to parse annotations in a test file.

See #6

R=rnystrom@google.com, kevmoo@google.com

Committed: https://github.com/dart-lang/unittest/commit/c5c1e7ea5551fca9dcbecaf53577d58ce84077fd

[nweiz, 2015-03-10 22:05:01]

nweiz@google.com changed reviewers:
+ rnystrom@google.com
- kevmoo@google.com

[nweiz, 2015-03-10 22:05:02]

Resending to Bob since Kevin's on vacation.

[Bob Nystrom, 2015-03-11 19:27:17]

https://codereview.chromium.org/986973006/diff/40001/lib/src/util/dart.dart
File lib/src/util/dart.dart (right):

https://codereview.chromium.org/986973006/diff/40001/lib/src/util/dart.dart#n...
lib/src/util/dart.dart:101: // TODO(nweiz): Avoid scanning the entire file when
issue 22745 is fixed.
I'm really surprised performance is an issue here. In my tests with the
formatter, I can process ~100kloc/s. Are you sure something else isn't going on?

If it were me, I'd just use parse directives and then look up the annotations on
the returned AST nodes.

https://codereview.chromium.org/986973006/diff/40001/test/util/parse_annotati...
File test/util/parse_annotations_test.dart (right):

https://codereview.chromium.org/986973006/diff/40001/test/util/parse_annotati...
test/util/parse_annotations_test.dart:127: }
Test that annotations after the first production aren't picked up.

Some tests involving comments (before, after, in the middle of an annotation,
etc.) are probably a good idea too.

[nweiz, 2015-03-12 19:24:33]

Code review changes

[nweiz, 2015-03-12 19:24:37]

https://codereview.chromium.org/986973006/diff/40001/lib/src/util/dart.dart
File lib/src/util/dart.dart (right):

https://codereview.chromium.org/986973006/diff/40001/lib/src/util/dart.dart#n...
lib/src/util/dart.dart:101: // TODO(nweiz): Avoid scanning the entire file when
issue 22745 is fixed.
On 2015/03/11 19:27:17, Bob Nystrom wrote:
> I'm really surprised performance is an issue here. In my tests with the
> formatter, I can process ~100kloc/s. Are you sure something else isn't going
on?
> 
> If it were me, I'd just use parse directives and then look up the annotations
on
> the returned AST nodes.

I was really trying to avoid spending much time on parsing, but I suppose the
simplicity of the existing API is probably better.

https://codereview.chromium.org/986973006/diff/40001/test/util/parse_annotati...
File test/util/parse_annotations_test.dart (right):

https://codereview.chromium.org/986973006/diff/40001/test/util/parse_annotati...
test/util/parse_annotations_test.dart:127: }
On 2015/03/11 19:27:17, Bob Nystrom wrote:
> Test that annotations after the first production aren't picked up.
> 
> Some tests involving comments (before, after, in the middle of an annotation,
> etc.) are probably a good idea too.

Done.

https://codereview.chromium.org/986973006/diff/40001/test/util/parse_annotati...
test/util/parse_annotations_test.dart:127: }
On 2015/03/11 19:27:17, Bob Nystrom wrote:
> Test that annotations after the first production aren't picked up.
> 
> Some tests involving comments (before, after, in the middle of an annotation,
> etc.) are probably a good idea too.

Done.

[Bob Nystrom, 2015-03-12 19:37:40]

https://codereview.chromium.org/986973006/diff/60001/lib/src/util/dart.dart
File lib/src/util/dart.dart (right):

https://codereview.chromium.org/986973006/diff/60001/lib/src/util/dart.dart#n...
lib/src/util/dart.dart:82: return directives.first.metadata;
How does this handle an empty file? I know it's a weird corner case, but it is a
valid Dart file.

[nweiz, 2015-03-12 19:52:08]

Code review changes

[nweiz, 2015-03-12 19:52:13]

https://codereview.chromium.org/986973006/diff/60001/lib/src/util/dart.dart
File lib/src/util/dart.dart (right):

https://codereview.chromium.org/986973006/diff/60001/lib/src/util/dart.dart#n...
lib/src/util/dart.dart:82: return directives.first.metadata;
On 2015/03/12 19:37:40, Bob Nystrom wrote:
> How does this handle an empty file? I know it's a weird corner case, but it is
a
> valid Dart file.

Good catch. Fixed.

[Bob Nystrom, 2015-03-12 20:14:15]

lgtm

[nweiz, 2015-03-12 20:17:03]

Committed patchset #5 (id:80001) manually as
c5c1e7ea5551fca9dcbecaf53577d58ce84077fd (presubmit successful).