Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(97)

Issue 986663004: Allow sending duplicate notifications. (Closed)

Created:
5 years, 9 months ago by scheglov
Modified:
5 years, 9 months ago
CC:
reviews_dartlang.org
Target Ref:
refs/remotes/git-svn
Visibility:
Public.

Description

Allow sending duplicate notifications. This will "unfix" dartbug.com/22210 , but at the same time it will remove most of of expensive AnalysisContext calculations introduced in https://code.google.com/p/dart/source/detail?r=44305 It reduces "notices" tag percentage from 15 to a little above 3. Also, we don't produce errors for external sources, which was the main problem in dartbug.com/22210. There is also the same expensive computation in execution domain. I will address it in a separate CL. R=brianwilkerson@google.com, paulberry@google.com BUG= Committed: https://code.google.com/p/dart/source/detail?r=44330

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -57 lines) Patch
M pkg/analysis_server/lib/src/operation/operation_analysis.dart View 1 chunk +0 lines, -10 lines 0 comments Download
M pkg/analysis_server/test/analysis_server_test.dart View 1 chunk +0 lines, -47 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
scheglov
5 years, 9 months ago (2015-03-06 23:29:22 UTC) #1
Brian Wilkerson
LGTM
5 years, 9 months ago (2015-03-07 00:48:16 UTC) #2
scheglov
5 years, 9 months ago (2015-03-09 16:57:35 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as 44330 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698