Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(84)

Issue 98643009: Short curcuit the inlining when code in the middle of an expression is aborting. (Closed)

Created:
7 years ago by ngeoffray
Modified:
7 years ago
Reviewers:
karlklose
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Short curcuit the inlining when code in the middle of an expression is aborting. R=karlklose@google.com Committed: https://code.google.com/p/dart/source/detail?r=31226

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Patch Set 4 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+30 lines, -5 lines) Patch
M sdk/lib/_internal/compiler/implementation/ssa/builder.dart View 1 2 3 4 chunks +12 lines, -3 lines 0 comments Download
M sdk/lib/_internal/compiler/implementation/ssa/from_ir_builder.dart View 1 2 3 1 chunk +0 lines, -2 lines 0 comments Download
A tests/language/issue15606_test.dart View 1 2 1 chunk +18 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
ngeoffray
7 years ago (2013-12-17 13:55:41 UTC) #1
karlklose
On 2013/12/17 13:55:41, ngeoffray wrote: LGTM.
7 years ago (2013-12-18 12:50:19 UTC) #2
karlklose
On 2013/12/17 13:55:41, ngeoffray wrote: LGTM.
7 years ago (2013-12-18 12:50:19 UTC) #3
ngeoffray
7 years ago (2013-12-18 15:18:23 UTC) #4
Message was sent while issue was closed.
Committed patchset #4 manually as r31226 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698