Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(645)

Issue 985913002: Remove more null receiver guards. (Closed)

Created:
5 years, 9 months ago by sra1
Modified:
5 years, 9 months ago
Reviewers:
floitsch, herhut
CC:
reviews_dartlang.org
Target Ref:
refs/remotes/git-svn
Visibility:
Public.

Description

Remove more null receiver guards. Sometimes when we inline methods with conditionals we have a graph that looks like: t1.toString; if (true) // Not actually included in output. t1.x = ... This change recognizes that t1 will be 'tested' for null by t1.x, so t1.toString can be removed. This is the single-path version of a fix for http://dartbug.com/22577 R=floitsch@google.com, herhut@google.com Committed: https://code.google.com/p/dart/source/detail?r=44323

Patch Set 1 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -7 lines) Patch
M pkg/compiler/lib/src/ssa/optimize.dart View 1 chunk +20 lines, -7 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
sra1
5 years, 9 months ago (2015-03-07 01:06:11 UTC) #3
herhut
lgtm
5 years, 9 months ago (2015-03-09 12:56:17 UTC) #4
floitsch
LGTM.
5 years, 9 months ago (2015-03-09 15:03:13 UTC) #6
sra1
5 years, 9 months ago (2015-03-09 15:26:57 UTC) #7
Message was sent while issue was closed.
Committed patchset #1 (id:20001) manually as 44323 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698