Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(602)

Issue 985533003: Make Socket address and port getters available after the socket is closed (Closed)

Created:
5 years, 9 months ago by Søren Gjesse
Modified:
5 years, 9 months ago
Reviewers:
Anders Johnsen
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Make Socket address and port getters available after the socket is closed There getters are used for generating eddor messages. TBR=ajohnsen@google.com BUG= Committed: https://code.google.com/p/dart/source/detail?r=44359

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -8 lines) Patch
M runtime/bin/socket_patch.dart View 3 chunks +4 lines, -6 lines 0 comments Download
M tests/standalone/io/raw_socket_test.dart View 1 chunk +0 lines, -2 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Søren Gjesse
5 years, 9 months ago (2015-03-10 08:54:13 UTC) #1
Søren Gjesse
Committed patchset #1 (id:1) manually as 44359 (presubmit successful).
5 years, 9 months ago (2015-03-10 08:54:42 UTC) #2
Anders Johnsen
5 years, 9 months ago (2015-03-10 09:06:28 UTC) #3
Message was sent while issue was closed.
LGTM.

Powered by Google App Engine
This is Rietveld 408576698