Issue 98533004: update TemplateBinding and Custom Elements polyfills

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 98533004: update TemplateBinding and Custom Elements polyfills (Closed)

Created:
7 years ago by Jennifer Messerly

Modified:
7 years ago

Reviewers:
blois

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

update TemplateBinding to 119bbab376aa4a8ee96a5354e3ebe84395d1da62 * fixes an issue where not having a sub-template results in incorrect custom element upgrade. update custom elements to 93a27b791d4bfdddad3be17fccda3c5052bf4a16 * needed to work with the latest TemplateBinding (specifically the importNode fix) Note that custom elements code is from: https://github.com/dart-lang/CustomElements/pull/1 R=blois@google.com Committed: https://code.google.com/p/dart/source/detail?r=30868

Patch Set 1 #

Patch Set 2 : update pubspecs #

Created: 7 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+425 lines, -409 lines)			Patch
M	pkg/custom_element/lib/custom-elements.debug.js	View		18 chunks	+392 lines, -379 lines	0 comments	Download
M	pkg/custom_element/lib/custom-elements.min.js	View		1 chunk	+1 line, -1 line	0 comments	Download
M	pkg/custom_element/pubspec.yaml	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	pkg/template_binding/lib/src/instance_binding_map.dart	View		2 chunks	+3 lines, -14 lines	0 comments	Download
M	pkg/template_binding/lib/src/template.dart	View		6 chunks	+26 lines, -12 lines	0 comments	Download
M	pkg/template_binding/pubspec.yaml	View	1	2 chunks	+2 lines, -2 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Jennifer Messerly

7 years ago (2013-12-04 21:00:04 UTC) #3

Message was sent while issue was closed.

Committed patchset #2 manually as r30868 (presubmit successful).

Expand Messages | Collapse Messages