Allow direct access to type parameters from factory (issue 22700).

Allow direct access to type parameters from factory (issue 22700).
Add regression test.
Fix wrong test and update status files.

Committed: https://code.google.com/p/dart/source/detail?r=44339

[regis, 2015-03-06 23:37:06]

regis@google.com changed reviewers:
+ iposva@google.com

[Ivan Posva, 2015-03-09 16:48:07]

LGTMwC -ip

https://codereview.chromium.org/985203002/diff/20001/tests/language/regress_2...
File tests/language/regress_22700_test.dart (right):

https://codereview.chromium.org/985203002/diff/20001/tests/language/regress_2...
tests/language/regress_22700_test.dart:22: new MyClass<String>.works2();
It would be nice if the test also verified that not only can we access the T
type parameter from within the factory constructor, but also check that it is
actually the type being passed in.

How about instead of calling print directly call a helper printAndCheck()? Such
as below or something even better:

printAndCheck(t) {
  print(t);
  Expect.equals(String, t);
}

[regis, 2015-03-09 19:39:05]

Thanks!

https://codereview.chromium.org/985203002/diff/20001/tests/language/regress_2...
File tests/language/regress_22700_test.dart (right):

https://codereview.chromium.org/985203002/diff/20001/tests/language/regress_2...
tests/language/regress_22700_test.dart:22: new MyClass<String>.works2();
On 2015/03/09 16:48:07, Ivan Posva wrote:
> It would be nice if the test also verified that not only can we access the T
> type parameter from within the factory constructor, but also check that it is
> actually the type being passed in.
> 
> How about instead of calling print directly call a helper printAndCheck()?
Such
> as below or something even better:
> 
> printAndCheck(t) {
>   print(t);
>   Expect.equals(String, t);
> }

Done.

[regis, 2015-03-09 19:39:25]

Committed patchset #3 (id:40001) manually as r44339 (presubmit successful).