fix completion target handling of comments

fix completion target handling of comments

The intent is to normalize the completion target returned given different comment arrangements.
This is a precursor to the fix for code completions given preceeding comments.

BUG=dartbug.com/22686
R=paulberry@google.com

Committed: https://code.google.com/p/dart/source/detail?r=44408

[danrubel, 2015-03-06 23:19:15]

danrubel@google.com changed reviewers:
+ paulberry@google.com

[Paul Berry, 2015-03-09 22:32:51]

lgtm

https://codereview.chromium.org/985183003/diff/1/pkg/analysis_server/test/ser...
File pkg/analysis_server/test/services/completion/completion_target_test.dart
(right):

https://codereview.chromium.org/985183003/diff/1/pkg/analysis_server/test/ser...
pkg/analysis_server/test/services/completion/completion_target_test.dart:267: 
I'd suggest adding some corner cases to test that the end of the comment is
detected correctly, e.g.:

1. Insertion point right after single-line comment:

// Comment
^zoo(z)

2. Insertion point right after C-style comment:

/* Comment */^ zoo(z)

3. Insertion point just before end of C-style comment (but still inside it):

/* Comment *^/ zoo(z)

Note that case 3 above should be considered inside the comment, since any
identifier typed at the insertion point will break the comment terminator and
therefore add text to the body of the comment.

[danrubel, 2015-03-11 15:01:56]

https://codereview.chromium.org/985183003/diff/1/pkg/analysis_server/test/ser...
File pkg/analysis_server/test/services/completion/completion_target_test.dart
(right):

https://codereview.chromium.org/985183003/diff/1/pkg/analysis_server/test/ser...
pkg/analysis_server/test/services/completion/completion_target_test.dart:267: 
On 2015/03/09 22:32:51, Paul Berry wrote:
> I'd suggest adding some corner cases to test that the end of the comment is
> detected correctly, e.g.:
> 
> 1. Insertion point right after single-line comment:
> 
> // Comment
> ^zoo(z)
> 
> 2. Insertion point right after C-style comment:
> 
> /* Comment */^ zoo(z)
> 
> 3. Insertion point just before end of C-style comment (but still inside it):
> 
> /* Comment *^/ zoo(z)
> 
> Note that case 3 above should be considered inside the comment, since any
> identifier typed at the insertion point will break the comment terminator and
> therefore add text to the body of the comment.

Great suggestion. Done.

[danrubel, 2015-03-11 17:38:58]

Committed patchset #4 (id:60001) manually as 44408 (presubmit successful).