Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(181)

Issue 984683002: Allow command aliases in Observatory debugger. (Closed)

Created:
5 years, 9 months ago by turnidge
Modified:
5 years, 9 months ago
Reviewers:
Cutch
CC:
reviews_dartlang.org, Cutch, vm-dev_dartlang.org
Target Ref:
refs/remotes/git-svn
Visibility:
Public.

Description

Allow command aliases in Observatory debugger. This will let us use 'c' for continue even though it is ambiguous. Add aliases to the 'help' output. BUG= R=johnmccutchan@google.com Committed: https://code.google.com/p/dart/source/detail?r=44269

Patch Set 1 #

Patch Set 2 : add test #

Patch Set 3 : code review #

Unified diffs Side-by-side diffs Delta from patch set Stats (+37 lines, -7 lines) Patch
M runtime/observatory/lib/src/cli/command.dart View 1 2 2 chunks +3 lines, -1 line 0 comments Download
M runtime/observatory/lib/src/elements/debugger.dart View 1 2 6 chunks +20 lines, -6 lines 0 comments Download
M runtime/observatory/test/command_test.dart View 1 1 chunk +14 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
turnidge
5 years, 9 months ago (2015-03-05 19:30:40 UTC) #2
Cutch
lgtm
5 years, 9 months ago (2015-03-05 19:36:01 UTC) #3
turnidge
5 years, 9 months ago (2015-03-05 19:44:26 UTC) #4
Message was sent while issue was closed.
Committed patchset #3 (id:40001) manually as 44269 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698