Fixed a number of bugs on RawSocket and Socket

Fixed a number of bugs on RawSocket and Socket

The checking of the closed state was not present when dealing
with the properties port, remotePort, address and remoteAddress
on RawSocket and Socket. Then now all throw SocketException when
the RawSocket or Socket is closed.

* Calling port on a RawSocket would return the port even if it
  was closed

* Calling remotePort, address and remoteAddress did not check for
  OSError

* Calling remotePort, address and remoteAddress on a closed
  RawSocket caused syscalls using the already closed fd, which
  might also have been re-allocated already.

* Calling port, remotePort, address and remoteAddress on a closed
  Socket caused null pointer exception

R=ajohnsen@google.com

Correctly check for errors when getting remote address and port

BUG=

Committed: https://code.google.com/p/dart/source/detail?r=44319

[Anders Johnsen, 2015-03-09 12:00:45]

LGTM! Very nice.

https://codereview.chromium.org/984403004/diff/1/runtime/bin/socket_patch.dart
File runtime/bin/socket_patch.dart (right):

https://codereview.chromium.org/984403004/diff/1/runtime/bin/socket_patch.dar...
runtime/bin/socket_patch.dart:695: InternetAddress get address {
This is a breaking change. Before we allowed the user to read a cached value
after the socket was closed, now we don't. Not sure if we need to announce this.

https://codereview.chromium.org/984403004/diff/1/tests/standalone/io/raw_sock...
File tests/standalone/io/raw_socket_test.dart (right):

https://codereview.chromium.org/984403004/diff/1/tests/standalone/io/raw_sock...
tests/standalone/io/raw_socket_test.dart:453: socket.port;
use Expect.throws instead?

[Søren Gjesse, 2015-03-09 13:33:39]

Committed patchset #1 (id:1) manually as 44319 (presubmit successful).

[Søren Gjesse, 2015-03-09 13:33:46]

https://codereview.chromium.org/984403004/diff/1/runtime/bin/socket_patch.dart
File runtime/bin/socket_patch.dart (right):

https://codereview.chromium.org/984403004/diff/1/runtime/bin/socket_patch.dar...
runtime/bin/socket_patch.dart:695: InternetAddress get address {
On 2015/03/09 12:00:45, Anders Johnsen wrote:
> This is a breaking change. Before we allowed the user to read a cached value
> after the socket was closed, now we don't. Not sure if we need to announce
this.

Yes (I had to fix a test), it is the same for port if it was already known. I
will think about whether sending out an announcement.

https://codereview.chromium.org/984403004/diff/1/tests/standalone/io/raw_sock...
File tests/standalone/io/raw_socket_test.dart (right):

https://codereview.chromium.org/984403004/diff/1/tests/standalone/io/raw_sock...
tests/standalone/io/raw_socket_test.dart:453: socket.port;
On 2015/03/09 12:00:45, Anders Johnsen wrote:
> use Expect.throws instead?

Done.