Issue 98423006: Remove deprecated mirror API from dart2js.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 98423006: Remove deprecated mirror API from dart2js. (Closed)

Created:
7 years ago by rmacnak

Modified:
7 years ago

Reviewers:
ahe

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

Remove deprecated mirror API from dart2js. BUG=http://dartbug.com/14878 R=ahe@google.com Committed: https://code.google.com/p/dart/source/detail?r=30879

Created: 7 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+49 lines, -50 lines)			Patch
	M	sdk/lib/_internal/lib/js_mirrors.dart	View	1 2	22 chunks	+49 lines, -49 lines	0 comments	Download
	M	tests/lib/lib.status	View	1	1 chunk	+0 lines, -1 line	0 comments	Download

Total messages: 5 (0 generated)

ahe

Thank you, LGTM! To minimize churn, could you rename the deprecated methods to use two ...

7 years ago (2013-12-04 23:17:01 UTC) #2

rmacnak

On 2013/12/04 23:17:01, ahe wrote: > Thank you, LGTM! > > To minimize churn, could ...

7 years ago (2013-12-04 23:50:43 UTC) #3

Message was sent while issue was closed.

Committed patchset #3 manually as r30879 (presubmit successful).