Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1142)

Issue 984133004: Split the constructors group in element_types_test into multiple files to narrow down timeouts (Closed)

Created:
5 years, 9 months ago by Alan Knight
Modified:
5 years, 9 months ago
Reviewers:
Bill Hesse
CC:
reviews_dartlang.org, terry
Target Ref:
refs/remotes/git-svn
Visibility:
Public.

Description

Split the constructors group in element_types_test into multiple files to narrow down timeouts BUG= R=whesse@google.com Committed: https://code.google.com/p/dart/source/detail?r=44327

Patch Set 1 #

Patch Set 2 : Change the status of the original test as well #

Unified diffs Side-by-side diffs Delta from patch set Stats (+218 lines, -105 lines) Patch
A tests/html/element_types_constructors1_test.dart View 1 chunk +40 lines, -0 lines 0 comments Download
A tests/html/element_types_constructors2_test.dart View 1 chunk +39 lines, -0 lines 0 comments Download
A tests/html/element_types_constructors3_test.dart View 1 chunk +41 lines, -0 lines 0 comments Download
A tests/html/element_types_constructors4_test.dart View 1 chunk +36 lines, -0 lines 0 comments Download
A tests/html/element_types_constructors5_test.dart View 1 chunk +37 lines, -0 lines 0 comments Download
A tests/html/element_types_constructors6_test.dart View 1 chunk +25 lines, -0 lines 0 comments Download
M tests/html/element_types_test.dart View 1 chunk +0 lines, -104 lines 0 comments Download
M tests/html/html.status View 1 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 5 (1 generated)
Alan Knight
5 years, 9 months ago (2015-03-06 21:48:44 UTC) #2
Bill Hesse
LGTM. Do you also want to change the status of the original test, to see ...
5 years, 9 months ago (2015-03-09 10:17:35 UTC) #3
Alan Knight
Good point. Done.
5 years, 9 months ago (2015-03-09 16:41:20 UTC) #4
Alan Knight
5 years, 9 months ago (2015-03-09 16:42:25 UTC) #5
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as 44327 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698