Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(134)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 983713002: Remove 'dart:io' import in builtin.dart (Closed)

Created:
5 years, 9 months ago by Cutch
Modified:
5 years, 9 months ago
Reviewers:
Ivan Posva
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Target Ref:
refs/remotes/git-svn
Visibility:
Public.

Description

Remove 'dart:io' import in builtin.dart BUG= R=iposva@google.com Committed: https://code.google.com/p/dart/source/detail?r=44274

Patch Set 1 #

Total comments: 2

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -96 lines) Patch
M runtime/bin/builtin.dart View 1 5 chunks +3 lines, -84 lines 0 comments Download
M runtime/bin/builtin_natives.cc View 1 chunk +1 line, -0 lines 0 comments Download
M runtime/bin/dartutils.cc View 4 chunks +12 lines, -12 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
Cutch
5 years, 9 months ago (2015-03-05 15:23:10 UTC) #2
Ivan Posva
LGTM -ip
5 years, 9 months ago (2015-03-05 17:57:57 UTC) #3
Ivan Posva
https://codereview.chromium.org/983713002/diff/1/runtime/bin/builtin.dart File runtime/bin/builtin.dart (right): https://codereview.chromium.org/983713002/diff/1/runtime/bin/builtin.dart#newcode8 runtime/bin/builtin.dart:8: import 'dart:isolate'; Please make a note here to NOT ...
5 years, 9 months ago (2015-03-05 17:58:37 UTC) #4
Cutch
https://codereview.chromium.org/983713002/diff/1/runtime/bin/builtin.dart File runtime/bin/builtin.dart (right): https://codereview.chromium.org/983713002/diff/1/runtime/bin/builtin.dart#newcode8 runtime/bin/builtin.dart:8: import 'dart:isolate'; On 2015/03/05 17:58:36, Ivan Posva wrote: > ...
5 years, 9 months ago (2015-03-06 00:02:18 UTC) #5
Cutch
5 years, 9 months ago (2015-03-06 00:18:02 UTC) #6
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) manually as 44274 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698