Replace Linked{Identity,Custom}Hash{Map,Set} with compact implementation; remove old code and flag.

Replace Linked{Identity,Custom}Hash{Map,Set} with compact implementation; remove old code and flag.

R=iposva@google.com

Committed: https://code.google.com/p/dart/source/detail?r=44294

[Ivan Posva, 2015-03-05 20:45:34]

LGTM.

At some point in the future we might want to drop the Compact prefix in the
class names.

-Ivan

https://codereview.chromium.org/983703003/diff/40001/runtime/lib/compact_hash...
File runtime/lib/compact_hash.dart (right):

https://codereview.chromium.org/983703003/diff/40001/runtime/lib/compact_hash...
runtime/lib/compact_hash.dart:71: abstract class _OperatorEqualsAndHashCode {
Why "abstract"?

https://codereview.chromium.org/983703003/diff/40001/runtime/lib/compact_hash...
runtime/lib/compact_hash.dart:85: implements HashMap<K, V>, LinkedHashMap<K, V>
{
I think you can drop the "HashMap<K,V>" from the implements as this is implied
by LinkedHashMap.

[koda, 2015-03-06 01:42:14]

On 2015/03/05 20:45:34, Ivan Posva wrote:
> LGTM.
> 
> At some point in the future we might want to drop the Compact prefix in the
> class names.

Agreed; and at that point I'll also rename the file.

> 
> -Ivan
> 
>
https://codereview.chromium.org/983703003/diff/40001/runtime/lib/compact_hash...
> File runtime/lib/compact_hash.dart (right):
> 
>
https://codereview.chromium.org/983703003/diff/40001/runtime/lib/compact_hash...
> runtime/lib/compact_hash.dart:71: abstract class _OperatorEqualsAndHashCode {
> Why "abstract"?
> 
>
https://codereview.chromium.org/983703003/diff/40001/runtime/lib/compact_hash...
> runtime/lib/compact_hash.dart:85: implements HashMap<K, V>, LinkedHashMap<K,
V>
> {
> I think you can drop the "HashMap<K,V>" from the implements as this is implied
> by LinkedHashMap.

[koda, 2015-03-06 15:13:15]

Committed patchset #3 (id:40001) manually as r44294 (presubmit successful).