Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(850)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 983573002: Add support for running browser tests to the test runner. (Closed)

Created:
5 years, 9 months ago by nweiz
Modified:
5 years, 9 months ago
Reviewers:
kevmoo
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/unittest@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Add support for running browser tests to the test runner. Closes #5 R=kevmoo@google.com Committed: https://github.com/dart-lang/unittest/commit/7597811a202bd43ffd550c7c41b68a8802fbcae9

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+586 lines, -79 lines) Patch
M bin/unittest.dart View 4 chunks +14 lines, -4 lines 0 comments Download
M lib/src/backend/suite.dart View 1 chunk +10 lines, -4 lines 0 comments Download
M lib/src/runner/browser/browser_manager.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M lib/src/runner/browser/compiler_pool.dart View 3 chunks +9 lines, -5 lines 0 comments Download
M lib/src/runner/browser/iframe_listener.dart View 1 chunk +2 lines, -3 lines 0 comments Download
M lib/src/runner/browser/server.dart View 3 chunks +8 lines, -5 lines 0 comments Download
M lib/src/runner/loader.dart View 4 chunks +56 lines, -14 lines 0 comments Download
M lib/src/runner/reporter/compact.dart View 3 chunks +19 lines, -5 lines 0 comments Download
M lib/src/runner/reporter/no_io_compact.dart View 3 chunks +19 lines, -5 lines 2 comments Download
A lib/src/runner/test_platform.dart View 1 chunk +33 lines, -0 lines 0 comments Download
M lib/src/runner/vm/isolate_listener.dart View 1 chunk +1 line, -2 lines 0 comments Download
M lib/unittest.dart View 1 chunk +3 lines, -1 line 0 comments Download
M test/backend/declarer_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M test/backend/invoker_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M test/io.dart View 2 chunks +1 line, -2 lines 0 comments Download
A test/runner/browser/compact_reporter_test.dart View 1 chunk +43 lines, -0 lines 0 comments Download
A test/runner/browser/compiler_pool_test.dart View 1 chunk +59 lines, -0 lines 0 comments Download
A test/runner/browser/loader_test.dart View 1 chunk +113 lines, -0 lines 0 comments Download
A test/runner/browser/runner_test.dart View 1 chunk +161 lines, -0 lines 0 comments Download
M test/runner/compact_reporter_test.dart View 3 chunks +5 lines, -7 lines 0 comments Download
M test/runner/engine_test.dart View 5 chunks +6 lines, -6 lines 0 comments Download
M test/runner/isolate_listener_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M test/runner/loader_test.dart View 6 chunks +15 lines, -10 lines 0 comments Download
M test/runner/runner_test.dart View 1 chunk +3 lines, -0 lines 0 comments Download
M test/utils.dart View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
nweiz
5 years, 9 months ago (2015-03-05 01:53:21 UTC) #1
kevmoo
lgtm https://codereview.chromium.org/983573002/diff/1/lib/src/runner/reporter/no_io_compact.dart File lib/src/runner/reporter/no_io_compact.dart (right): https://codereview.chromium.org/983573002/diff/1/lib/src/runner/reporter/no_io_compact.dart#newcode1 lib/src/runner/reporter/no_io_compact.dart:1: // Copyright (c) 2015, the Dart project authors. ...
5 years, 9 months ago (2015-03-05 23:14:29 UTC) #2
nweiz
https://codereview.chromium.org/983573002/diff/1/lib/src/runner/reporter/no_io_compact.dart File lib/src/runner/reporter/no_io_compact.dart (right): https://codereview.chromium.org/983573002/diff/1/lib/src/runner/reporter/no_io_compact.dart#newcode1 lib/src/runner/reporter/no_io_compact.dart:1: // Copyright (c) 2015, the Dart project authors. Please ...
5 years, 9 months ago (2015-03-06 01:40:02 UTC) #3
nweiz
5 years, 9 months ago (2015-03-06 01:40:16 UTC) #4
Message was sent while issue was closed. 
Committed patchset #1 (id:1) manually as
7597811a202bd43ffd550c7c41b68a8802fbcae9 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698