Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(517)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 983363005: Flag that --dump-info is not supported for dart2dart. (Closed)

Created:
5 years, 9 months ago by Johnni Winther
Modified:
5 years, 9 months ago
Reviewers:
floitsch
CC:
reviews_dartlang.org
Target Ref:
refs/remotes/git-svn
Visibility:
Public.

Description

Flag that --dump-info is not supported for dart2dart. BUG=http://dartbug.com/22724 R=floitsch@google.com Committed: https://code.google.com/p/dart/source/detail?r=44400

Patch Set 1 #

Total comments: 2

Patch Set 2 : Updated cf. comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -2 lines) Patch
M pkg/compiler/lib/src/compiler.dart View 1 chunk +3 lines, -0 lines 0 comments Download
M pkg/compiler/lib/src/dart2js.dart View 1 5 chunks +14 lines, -2 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
Johnni Winther
5 years, 9 months ago (2015-03-09 13:26:56 UTC) #2
floitsch
LGTM. https://codereview.chromium.org/983363005/diff/1/pkg/compiler/lib/src/dart2js.dart File pkg/compiler/lib/src/dart2js.dart (right): https://codereview.chromium.org/983363005/diff/1/pkg/compiler/lib/src/dart2js.dart#newcode619 pkg/compiler/lib/src/dart2js.dart:619: This is features is currently not supported in ...
5 years, 9 months ago (2015-03-09 15:06:22 UTC) #3
Johnni Winther
https://codereview.chromium.org/983363005/diff/1/pkg/compiler/lib/src/dart2js.dart File pkg/compiler/lib/src/dart2js.dart (right): https://codereview.chromium.org/983363005/diff/1/pkg/compiler/lib/src/dart2js.dart#newcode619 pkg/compiler/lib/src/dart2js.dart:619: This is features is currently not supported in combination ...
5 years, 9 months ago (2015-03-11 13:08:45 UTC) #4
Johnni Winther
5 years, 9 months ago (2015-03-11 13:13:07 UTC) #5
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) manually as 44400 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698