Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(380)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 982723002: Fix for issue 20992 - Allow sending static/top-level functions to other isolates which are spawned … (Closed)

Created:
5 years, 9 months ago by siva
Modified:
5 years, 9 months ago
Reviewers:
regis
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Visibility:
Public.

Description

Fix for issue 20992 - Allow sending static/top-level functions to other isolates which are spawned using the 'spawn function' functionality. R=regis@google.com Committed: https://code.google.com/p/dart/source/detail?r=44297

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Total comments: 4

Patch Set 4 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+328 lines, -35 lines) Patch
M runtime/vm/object.h View 1 2 3 3 chunks +7 lines, -0 lines 0 comments Download
M runtime/vm/object.cc View 1 2 2 chunks +24 lines, -4 lines 0 comments Download
M runtime/vm/raw_object.h View 1 4 chunks +7 lines, -0 lines 0 comments Download
M runtime/vm/snapshot.h View 1 3 chunks +7 lines, -1 line 0 comments Download
M runtime/vm/snapshot.cc View 1 2 3 10 chunks +158 lines, -27 lines 0 comments Download
M runtime/vm/snapshot_ids.h View 1 2 chunks +2 lines, -1 line 0 comments Download
A tests/isolate/function_send1_test.dart View 1 chunk +118 lines, -0 lines 0 comments Download
M tests/isolate/isolate.status View 1 3 chunks +5 lines, -2 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
siva
5 years, 9 months ago (2015-03-05 23:11:16 UTC) #2
regis
LGTM https://codereview.chromium.org/982723002/diff/40001/runtime/vm/object.h File runtime/vm/object.h (right): https://codereview.chromium.org/982723002/diff/40001/runtime/vm/object.h#newcode7340 runtime/vm/object.h:7340: static RawFunction* function(RawObject* obj) { Are you overloading ...
5 years, 9 months ago (2015-03-05 23:35:20 UTC) #3
siva
https://codereview.chromium.org/982723002/diff/40001/runtime/vm/object.h File runtime/vm/object.h (right): https://codereview.chromium.org/982723002/diff/40001/runtime/vm/object.h#newcode7340 runtime/vm/object.h:7340: static RawFunction* function(RawObject* obj) { On 2015/03/05 23:35:19, regis ...
5 years, 9 months ago (2015-03-06 00:30:56 UTC) #4
siva
5 years, 9 months ago (2015-03-06 18:51:25 UTC) #5
Message was sent while issue was closed. 
Committed patchset #4 (id:60001) manually as r44297 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698