Issue 982243002: Disable incremental resolution of comments outside function bodies.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 982243002: Disable incremental resolution of comments outside function bodies. (Closed)

Created:
5 years, 9 months ago by scheglov

Modified:
5 years, 9 months ago

Reviewers:
Brian Wilkerson

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Target Ref:
refs/remotes/git-svn

Visibility:
Public.

More Reviews

Description

Disable incremental resolution of comments outside function bodies. It causes disappearing of semantic highlighting and navigation for the first node after a just added comment. Unfortunately there is no easy way to add/remove comment tokens. We can replace tokens, but we need also to replace tokens in nodes. Given that we are in a cherry picking season, let's implement the simplest correct solution. R=brianwilkerson@google.com BUG= https://code.google.com/p/dart/issues/detail?id=22644 Committed: https://code.google.com/p/dart/source/detail?r=44295

Patch Set 1 #

Created: 5 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+13 lines, -50 lines)			Patch
	M	pkg/analyzer/lib/src/generated/incremental_resolver.dart	View		4 chunks	+7 lines, -44 lines	0 comments	Download
	M	pkg/analyzer/test/generated/incremental_resolver_test.dart	View		4 chunks	+6 lines, -6 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

scheglov

5 years, 9 months ago (2015-03-06 16:53:36 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as 44295 (presubmit successful).

Expand Messages | Collapse Messages