Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(247)

Issue 98183006: Fixing Window.animationFrame timing issue (Closed)

Created:
6 years, 11 months ago by blois
Modified:
6 years, 11 months ago
Reviewers:
Emily Fortuna
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Fixing Window.animationFrame timing issue Was using async completer which changes the timing. Additional Dartium changes are from https://codereview.chromium.org//111613002 which did not re-gen the Dartium file. BUG=15848 R=efortuna@google.com Committed: https://code.google.com/p/dart/source/detail?r=31590

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -14 lines) Patch
M sdk/lib/html/dart2js/html_dart2js.dart View 1 chunk +1 line, -1 line 0 comments Download
M sdk/lib/html/dartium/html_dartium.dart View 3 chunks +12 lines, -12 lines 0 comments Download
M tools/dom/templates/html/impl/impl_Window.darttemplate View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 3 (0 generated)
blois
6 years, 11 months ago (2014-01-02 19:25:14 UTC) #1
Emily Fortuna
lgtm
6 years, 11 months ago (2014-01-02 19:40:52 UTC) #2
blois
6 years, 11 months ago (2014-01-07 23:33:52 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r31590 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698