dart2js: split out types from metadata.

dart2js: split out types from metadata.

R=floitsch@google.com

Committed: https://code.google.com/p/dart/source/detail?r=44292

[zarah, 2015-03-06 09:01:14]

zarah@google.com changed reviewers:
+ herhut@google.com

[floitsch, 2015-03-06 12:48:50]

floitsch@google.com changed reviewers:
+ floitsch@google.com

[floitsch, 2015-03-06 12:48:51]

LGTM.

https://codereview.chromium.org/981143003/diff/1/pkg/compiler/lib/src/js_emit...
File pkg/compiler/lib/src/js_emitter/metadata_collector.dart (right):

https://codereview.chromium.org/981143003/diff/1/pkg/compiler/lib/src/js_emit...
pkg/compiler/lib/src/js_emitter/metadata_collector.dart:20: final List<String>
types = [];
Make it typed? (same for the globalMetadata)

https://codereview.chromium.org/981143003/diff/1/pkg/compiler/lib/src/js_emit...
pkg/compiler/lib/src/js_emitter/metadata_collector.dart:121: int addType(String
string) {
Not this CL, but we should consider storing the jsAst.

https://codereview.chromium.org/981143003/diff/1/pkg/compiler/lib/src/js_emit...
pkg/compiler/lib/src/js_emitter/metadata_collector.dart:121: int addType(String
string) {
s/string/code
s/string/compiledType
?

https://codereview.chromium.org/981143003/diff/1/pkg/compiler/lib/src/js_emit...
File pkg/compiler/lib/src/js_emitter/model.dart (right):

https://codereview.chromium.org/981143003/diff/1/pkg/compiler/lib/src/js_emit...
pkg/compiler/lib/src/js_emitter/model.dart:49: /// The list references constants
and must hence be emitted after constants
Do you know if this is still the case?

[zarah, 2015-03-06 13:05:52]

Thanks!

https://codereview.chromium.org/981143003/diff/1/pkg/compiler/lib/src/js_emit...
File pkg/compiler/lib/src/js_emitter/metadata_collector.dart (right):

https://codereview.chromium.org/981143003/diff/1/pkg/compiler/lib/src/js_emit...
pkg/compiler/lib/src/js_emitter/metadata_collector.dart:20: final List<String>
types = [];
On 2015/03/06 12:48:50, floitsch wrote:
> Make it typed? (same for the globalMetadata)

Done.

https://codereview.chromium.org/981143003/diff/1/pkg/compiler/lib/src/js_emit...
pkg/compiler/lib/src/js_emitter/metadata_collector.dart:121: int addType(String
string) {
On 2015/03/06 12:48:50, floitsch wrote:
> Not this CL, but we should consider storing the jsAst.

Acknowledged.

https://codereview.chromium.org/981143003/diff/1/pkg/compiler/lib/src/js_emit...
pkg/compiler/lib/src/js_emitter/metadata_collector.dart:121: int addType(String
string) {
On 2015/03/06 12:48:50, floitsch wrote:
> s/string/code
> s/string/compiledType
> ?

I like compiledType.

https://codereview.chromium.org/981143003/diff/1/pkg/compiler/lib/src/js_emit...
File pkg/compiler/lib/src/js_emitter/model.dart (right):

https://codereview.chromium.org/981143003/diff/1/pkg/compiler/lib/src/js_emit...
pkg/compiler/lib/src/js_emitter/model.dart:49: /// The list references constants
and must hence be emitted after constants
On 2015/03/06 12:48:50, floitsch wrote:
> Do you know if this is still the case?

I believe it is since for instance the type variable types are constants.

[zarah, 2015-03-06 14:23:20]

Committed patchset #2 (id:20001) manually as 44292 (presubmit successful).