Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(113)

Issue 98103004: Dart2js: Make Int64List and Uint64List abstract. (Closed)

Created:
7 years ago by Lasse Reichstein Nielsen
Modified:
7 years ago
Reviewers:
ahe
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Make Int64List and Uint64List abstract. They are uninstantiable anyway, and this prevents warnings if they are missing implementation. BUG= http://dartbug.com/15418 R=ahe@google.com Committed: https://code.google.com/p/dart/source/detail?r=30883

Patch Set 1 #

Total comments: 4

Patch Set 2 : Indentation #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -2 lines) Patch
M sdk/lib/typed_data/dart2js/typed_data_dart2js.dart View 1 2 chunks +4 lines, -2 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
Lasse Reichstein Nielsen
7 years ago (2013-12-04 15:16:55 UTC) #1
Lasse Reichstein Nielsen
Dart2js only (which wasn't obvious from the summary).
7 years ago (2013-12-04 15:17:28 UTC) #2
ahe
LGTM, thank you! https://codereview.chromium.org/98103004/diff/1/sdk/lib/typed_data/dart2js/typed_data_dart2js.dart File sdk/lib/typed_data/dart2js/typed_data_dart2js.dart (right): https://codereview.chromium.org/98103004/diff/1/sdk/lib/typed_data/dart2js/typed_data_dart2js.dart#newcode1129 sdk/lib/typed_data/dart2js/typed_data_dart2js.dart:1129: implements JavaScriptIndexingBehavior, List<int> { Indent by ...
7 years ago (2013-12-04 15:24:26 UTC) #3
Lasse Reichstein Nielsen
https://codereview.chromium.org/98103004/diff/1/sdk/lib/typed_data/dart2js/typed_data_dart2js.dart File sdk/lib/typed_data/dart2js/typed_data_dart2js.dart (right): https://codereview.chromium.org/98103004/diff/1/sdk/lib/typed_data/dart2js/typed_data_dart2js.dart#newcode1129 sdk/lib/typed_data/dart2js/typed_data_dart2js.dart:1129: implements JavaScriptIndexingBehavior, List<int> { Ok. I do prefer aligning ...
7 years ago (2013-12-04 21:52:54 UTC) #4
ahe
https://codereview.chromium.org/98103004/diff/1/sdk/lib/typed_data/dart2js/typed_data_dart2js.dart File sdk/lib/typed_data/dart2js/typed_data_dart2js.dart (right): https://codereview.chromium.org/98103004/diff/1/sdk/lib/typed_data/dart2js/typed_data_dart2js.dart#newcode1129 sdk/lib/typed_data/dart2js/typed_data_dart2js.dart:1129: implements JavaScriptIndexingBehavior, List<int> { On 2013/12/04 21:52:54, Lasse Reichstein ...
7 years ago (2013-12-04 22:54:40 UTC) #5
Lasse Reichstein Nielsen
7 years ago (2013-12-05 08:58:21 UTC) #6
Message was sent while issue was closed.
Committed patchset #2 manually as r30883 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698