Issue 980203002: Fix dart2dart new_backend

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 980203002: Fix dart2dart new_backend (Closed)

Created:
5 years, 9 months ago by Johnni Winther

Modified:
5 years, 9 months ago

Reviewers:
asgerf

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Target Ref:
refs/remotes/git-svn

Visibility:
Public.

More Reviews

Description

Fix dart2dart new_backend BUG= R=asgerf@google.com Committed: https://code.google.com/p/dart/source/detail?r=44257

Patch Set 1 #

Total comments: 1

Created: 5 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+5 lines, -13 lines)			Patch
	M	pkg/compiler/lib/src/dart_backend/backend_ast_to_frontend_ast.dart	View		1 chunk	+5 lines, -6 lines	1 comment	Download
	M	tests/language/language_dart2js.status	View		1 chunk	+0 lines, -7 lines	0 comments	Download

Messages

Total messages: 4 (1 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

Johnni Winther

https://codereview.chromium.org/980203002/diff/1/pkg/compiler/lib/src/dart_backend/backend_ast_to_frontend_ast.dart File pkg/compiler/lib/src/dart_backend/backend_ast_to_frontend_ast.dart (right): https://codereview.chromium.org/980203002/diff/1/pkg/compiler/lib/src/dart_backend/backend_ast_to_frontend_ast.dart#newcode979 pkg/compiler/lib/src/dart_backend/backend_ast_to_frontend_ast.dart:979: definition = new tree.SendSet( This fixes a crash in ...

5 years, 9 months ago (2015-03-05 10:48:01 UTC) #2

Johnni Winther

5 years, 9 months ago (2015-03-05 11:24:36 UTC) #4

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as 44257 (presubmit successful).

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages