Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(23)

Issue 980043002: Enable loading via service isolate (Closed)

Created:
5 years, 9 months ago by Cutch
Modified:
5 years, 9 months ago
Reviewers:
Ivan Posva
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Target Ref:
refs/remotes/git-svn
Visibility:
Public.

Description

Enable loading via service isolate BUG= Committed: https://code.google.com/p/dart/source/detail?r=44251

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M runtime/bin/dartutils.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 5 (1 generated)
Cutch
TBR
5 years, 9 months ago (2015-03-05 01:37:08 UTC) #2
Cutch
Committed patchset #1 (id:1) manually as 44251 (presubmit successful).
5 years, 9 months ago (2015-03-05 01:37:18 UTC) #3
Ivan Posva
LGTM -ip
5 years, 9 months ago (2015-03-05 01:37:58 UTC) #4
nweiz
5 years, 9 months ago (2015-03-10 22:07:54 UTC) #5
Message was sent while issue was closed.
This CL changed an error message and consequently broke the pub bots. Please
investigate and fix either the error message or pub's detection.

In general, as we've asked before, please be aware that changes like this can
have broader effects than just VM and keep an eye on *all* the bots when you
make them.

Powered by Google App Engine
This is Rietveld 408576698