Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(126)

Issue 979813002: Support simple try in analyzer2dart. (Closed)

Created:
5 years, 9 months ago by Johnni Winther
Modified:
5 years, 9 months ago
CC:
reviews_dartlang.org
Target Ref:
refs/remotes/git-svn
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 4

Patch Set 2 : Updated cf. comments. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+254 lines, -124 lines) Patch
M pkg/analyzer2dart/lib/src/cps_generator.dart View 1 chunk +16 lines, -0 lines 0 comments Download
M pkg/analyzer2dart/test/end2end_data.dart View 1 1 chunk +34 lines, -1 line 0 comments Download
M pkg/analyzer2dart/test/sexpr_data.dart View 1 chunk +36 lines, -0 lines 0 comments Download
M pkg/compiler/lib/src/cps_ir/cps_ir_builder.dart View 4 chunks +152 lines, -0 lines 0 comments Download
M pkg/compiler/lib/src/cps_ir/cps_ir_builder_visitor.dart View 1 2 chunks +16 lines, -123 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
Johnni Winther
5 years, 9 months ago (2015-03-04 14:23:33 UTC) #2
Kevin Millikin (Google)
LGTM. I don't know how you're treating syntax that isn't handled yet. I guess you ...
5 years, 9 months ago (2015-03-04 14:45:54 UTC) #3
Paul Berry
analyzer2dart parts lgtm.
5 years, 9 months ago (2015-03-04 17:23:28 UTC) #4
Johnni Winther
https://codereview.chromium.org/979813002/diff/1/pkg/analyzer2dart/test/end2end_data.dart File pkg/analyzer2dart/test/end2end_data.dart (right): https://codereview.chromium.org/979813002/diff/1/pkg/analyzer2dart/test/end2end_data.dart#newcode877 pkg/analyzer2dart/test/end2end_data.dart:877: // TODO(kmilikin): Remove the unused stack trace parameter. On ...
5 years, 9 months ago (2015-03-05 09:10:27 UTC) #5
Johnni Winther
5 years, 9 months ago (2015-03-05 09:14:08 UTC) #6
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as 44253 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698