enterForLoop body should be in scope in for-loop update

Changed construction of 'for' loops so that bindings introduced in
enterLoopBody are in scope in the update part.

BUG=
R=kmillikin@google.com

Committed: https://code.google.com/p/dart/source/detail?r=44233

[asgerf, 2015-03-04 10:11:34]

asgerf@google.com changed reviewers:
+ kmillikin@google.com

[Kevin Millikin (Google), 2015-03-04 10:51:06]

LGTM.

https://codereview.chromium.org/979753002/diff/1/pkg/compiler/lib/src/cps_ir/...
File pkg/compiler/lib/src/cps_ir/cps_ir_builder.dart (right):

https://codereview.chromium.org/979753002/diff/1/pkg/compiler/lib/src/cps_ir/...
pkg/compiler/lib/src/cps_ir/cps_ir_builder.dart:952: //       [[enterBody]];
Maybe we should spell this _enterForLoopBody (to match the helper name, and
without the [[.]] brackets that informally indicate the translation of syntax).

And we should also be more explicit by also adding _enterForLoopInitializer and
_enterForLoopUpdate (and any other such helpers if I've missed them) at their
intended positions.

https://codereview.chromium.org/979753002/diff/1/pkg/compiler/lib/src/cps_ir/...
pkg/compiler/lib/src/cps_ir/cps_ir_builder.dart:980: IrBuilder outerBodyBuilder
= condBuilder.makeDelimitedBuilder();
I wish we weren't out of good names to use in this function.

[asgerf, 2015-03-04 13:34:09]

https://codereview.chromium.org/979753002/diff/1/pkg/compiler/lib/src/cps_ir/...
File pkg/compiler/lib/src/cps_ir/cps_ir_builder.dart (right):

https://codereview.chromium.org/979753002/diff/1/pkg/compiler/lib/src/cps_ir/...
pkg/compiler/lib/src/cps_ir/cps_ir_builder.dart:952: //       [[enterBody]];
On 2015/03/04 10:51:05, kmillikin wrote:
> Maybe we should spell this _enterForLoopBody (to match the helper name, and
> without the [[.]] brackets that informally indicate the translation of
syntax).
> 
> And we should also be more explicit by also adding _enterForLoopInitializer
and
> _enterForLoopUpdate (and any other such helpers if I've missed them) at their
> intended positions.

Done.

[Kevin Millikin (Google), 2015-03-04 13:36:12]

https://codereview.chromium.org/979753002/diff/1/pkg/compiler/lib/src/cps_ir/...
File pkg/compiler/lib/src/cps_ir/cps_ir_builder.dart (right):

https://codereview.chromium.org/979753002/diff/1/pkg/compiler/lib/src/cps_ir/...
pkg/compiler/lib/src/cps_ir/cps_ir_builder.dart:952: //       [[enterBody]];
On 2015/03/04 13:34:08, asgerf wrote:
> On 2015/03/04 10:51:05, kmillikin wrote:
> > Maybe we should spell this _enterForLoopBody (to match the helper name, and
> > without the [[.]] brackets that informally indicate the translation of
> syntax).
> > 
> > And we should also be more explicit by also adding _enterForLoopInitializer
> and
> > _enterForLoopUpdate (and any other such helpers if I've missed them) at
their
> > intended positions.
> 
> Done.

Excellent.

[asgerf, 2015-03-04 13:49:24]

Committed patchset #2 (id:20001) manually as 44233 (presubmit successful).