Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(527)

Issue 979513002: pkg/unittest: Add a server for serving test assets to browsers. (Closed)

Created:
5 years, 9 months ago by nweiz
Modified:
5 years, 9 months ago
Reviewers:
kevmoo
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/unittest@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Add a server for serving test assets to browsers. See #5 R=kevmoo@google.com Committed: https://github.com/dart-lang/unittest/commit/054c68148ca869efcdcbe5f2c99b99e72e1d7ce3

Patch Set 1 #

Patch Set 2 : merge #

Patch Set 3 : Fix loader_test. #

Total comments: 1

Patch Set 4 : Fix libDir. #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+319 lines, -134 lines) Patch
A lib/src/runner/browser/server.dart View 1 2 3 1 chunk +160 lines, -0 lines 0 comments Download
M lib/src/runner/browser/static/host.dart View 1 chunk +1 line, -4 lines 0 comments Download
M lib/src/runner/browser/static/host.dart.js View 11 chunks +96 lines, -99 lines 0 comments Download
M lib/src/runner/browser/static/host.dart.js.map View 1 chunk +3 lines, -3 lines 0 comments Download
M lib/src/runner/loader.dart View 1 2 2 chunks +3 lines, -9 lines 2 comments Download
M lib/src/util/io.dart View 1 2 2 chunks +39 lines, -2 lines 0 comments Download
M pubspec.yaml View 1 chunk +6 lines, -1 line 0 comments Download
M test/io.dart View 1 2 2 chunks +3 lines, -13 lines 0 comments Download
M test/runner/loader_test.dart View 1 2 1 chunk +8 lines, -3 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
nweiz
5 years, 9 months ago (2015-03-03 21:08:16 UTC) #1
kevmoo
In unchecked mode I get 1 failure (once the call to libDir() is fixed) 00:00 ...
5 years, 9 months ago (2015-03-04 20:30:38 UTC) #2
nweiz
I can't reproduce your test failures in checked or unchecked mode.
5 years, 9 months ago (2015-03-04 21:41:13 UTC) #3
kevmoo
lgtm https://codereview.chromium.org/979513002/diff/60001/lib/src/runner/loader.dart File lib/src/runner/loader.dart (right): https://codereview.chromium.org/979513002/diff/60001/lib/src/runner/loader.dart#newcode15 lib/src/runner/loader.dart:15: import '../util/io.dart'; unused import
5 years, 9 months ago (2015-03-04 23:41:04 UTC) #4
nweiz
https://codereview.chromium.org/979513002/diff/60001/lib/src/runner/loader.dart File lib/src/runner/loader.dart (right): https://codereview.chromium.org/979513002/diff/60001/lib/src/runner/loader.dart#newcode15 lib/src/runner/loader.dart:15: import '../util/io.dart'; On 2015/03/04 23:41:04, kevmoo wrote: > unused ...
5 years, 9 months ago (2015-03-05 01:08:02 UTC) #5
nweiz
5 years, 9 months ago (2015-03-05 01:08:14 UTC) #6
Message was sent while issue was closed.
Committed patchset #4 (id:60001) manually as
054c68148ca869efcdcbe5f2c99b99e72e1d7ce3 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698