Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(154)

Issue 978453003: add option to ImportCrawler to start from an already parsed document (Closed)

Created:
5 years, 9 months ago by jakemac
Modified:
5 years, 9 months ago
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/web-components.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

add option to ImportCrawler to start from an already parsed document R=sigmund@google.com Committed: https://github.com/dart-lang/core-elements/commit/d03f308607db38bca07327bef847727effebdcca

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+57 lines, -17 lines) Patch
M CHANGELOG.md View 1 chunk +5 lines, -0 lines 0 comments Download
M lib/build/import_crawler.dart View 3 chunks +23 lines, -11 lines 0 comments Download
M pubspec.yaml View 1 chunk +1 line, -1 line 0 comments Download
M test/build/import_crawler_test.dart View 4 chunks +28 lines, -5 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
jakemac
5 years, 9 months ago (2015-03-03 18:25:54 UTC) #2
Siggi Cherem (dart-lang)
lgtm nice... this code will get so much better once we start using await... it's ...
5 years, 9 months ago (2015-03-03 20:27:52 UTC) #3
jakemac
5 years, 9 months ago (2015-03-04 16:02:08 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
d03f308607db38bca07327bef847727effebdcca (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698