Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(10)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 978093003: Better configure the Chrome launcher. (Closed)

Created:
5 years, 9 months ago by nweiz
Modified:
5 years, 9 months ago
Reviewers:
kevmoo
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/unittest@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Better configure the Chrome launcher. This uses the right executables on OS X and Windows, and passes flags to disable even more features. R=kevmoo@google.com Committed: https://github.com/dart-lang/unittest/commit/e6f65753852bc93e2cd928d032da1e7f3411f0d8

Patch Set 1 #

Total comments: 2

Patch Set 2 : Code review changes #

Unified diffs Side-by-side diffs Delta from patch set Stats (+36 lines, -3 lines) Patch
M lib/src/runner/browser/chrome.dart View 1 4 chunks +36 lines, -3 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
nweiz
5 years, 9 months ago (2015-03-05 02:14:12 UTC) #1
kevmoo
lgtm
5 years, 9 months ago (2015-03-05 22:58:54 UTC) #2
kevmoo
https://codereview.chromium.org/978093003/diff/1/lib/src/runner/browser/chrome.dart File lib/src/runner/browser/chrome.dart (right): https://codereview.chromium.org/978093003/diff/1/lib/src/runner/browser/chrome.dart#newcode111 lib/src/runner/browser/chrome.dart:111: var path = p.join(prefix, suffix); spoke too soon: pkg/path ...
5 years, 9 months ago (2015-03-05 23:10:00 UTC) #3
nweiz
Code review changes
5 years, 9 months ago (2015-03-06 01:38:12 UTC) #4
nweiz
https://codereview.chromium.org/978093003/diff/1/lib/src/runner/browser/chrome.dart File lib/src/runner/browser/chrome.dart (right): https://codereview.chromium.org/978093003/diff/1/lib/src/runner/browser/chrome.dart#newcode111 lib/src/runner/browser/chrome.dart:111: var path = p.join(prefix, suffix); On 2015/03/05 23:10:00, kevmoo ...
5 years, 9 months ago (2015-03-06 01:38:19 UTC) #5
nweiz
5 years, 9 months ago (2015-03-06 01:38:34 UTC) #6
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) manually as
e6f65753852bc93e2cd928d032da1e7f3411f0d8 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698