Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(449)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 977943005: update mirror-based crawling to only run from relative path libraries that are unreachable by the m… (Closed)

Created:
5 years, 9 months ago by jakemac
Modified:
5 years, 9 months ago
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/static-init.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Only crawl from all relative libraries if in dartium, otherwise crawl from the root library only. R=sigmund@google.com Committed: https://github.com/dart-lang/initialize/commit/35b8066ea27f2ec3e9b9a6d44ed84d0b152f9154

Patch Set 1 #

Patch Set 2 : update comment #

Patch Set 3 : only crawl relative libraries in dartium #

Total comments: 4

Patch Set 4 : remove unused method and add todo #

Unified diffs Side-by-side diffs Delta from patch set Stats (+36 lines, -19 lines) Patch
M CHANGELOG.md View 1 2 1 chunk +5 lines, -0 lines 0 comments Download
M lib/src/mirror_loader.dart View 1 2 3 1 chunk +30 lines, -18 lines 0 comments Download
M pubspec.yaml View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 5 (1 generated)
jakemac
5 years, 9 months ago (2015-03-04 21:12:49 UTC) #2
Siggi Cherem (dart-lang)
lgtm https://codereview.chromium.org/977943005/diff/40001/lib/src/mirror_loader.dart File lib/src/mirror_loader.dart (right): https://codereview.chromium.org/977943005/diff/40001/lib/src/mirror_loader.dart#newcode44 lib/src/mirror_loader.dart:44: // In dartium, process all relative libraries in ...
5 years, 9 months ago (2015-03-04 22:12:26 UTC) #3
jakemac
Committed patchset #4 (id:60001) manually as 35b8066ea27f2ec3e9b9a6d44ed84d0b152f9154 (presubmit successful).
5 years, 9 months ago (2015-03-05 23:00:09 UTC) #4
jakemac
5 years, 9 months ago (2015-03-06 19:06:39 UTC) #5
Message was sent while issue was closed. 
https://codereview.chromium.org/977943005/diff/40001/lib/src/mirror_loader.dart
File lib/src/mirror_loader.dart (right):

https://codereview.chromium.org/977943005/diff/40001/lib/src/mirror_loader.da...
lib/src/mirror_loader.dart:44: // In dartium, process all relative libraries in
reverse order of when
On 2015/03/04 22:12:25, Siggi Cherem (dart-lang) wrote:
> let's add the TODO here saying that this logic shouldn't is an approximation
of
> what we want and point to the bug with the long term solution we discussed

Done.

https://codereview.chromium.org/977943005/diff/40001/lib/src/mirror_loader.da...
lib/src/mirror_loader.dart:77: Set<LibraryMirror> _visibleRelativeLibraries(
On 2015/03/04 22:12:25, Siggi Cherem (dart-lang) wrote:
> we can delete this now I think

Done.

Powered by Google App Engine
This is Rietveld 408576698