Issue 977553004: Translate constructors without bad references.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 977553004: Translate constructors without bad references. (Closed)

Created:
5 years, 9 months ago by asgerf

Modified:
5 years, 9 months ago

Reviewers:
sigurdm

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Target Ref:
refs/remotes/git-svn

Visibility:
Public.

More Reviews

Description

Translate constructors without bad references. This came up while working on integrity checks for the CPS IR. - Empty constructors to should not create orphaned references. - Initializers should not use the body's return continuation object, they should each have their own. BUG= R=sigurdm@google.com Committed: https://code.google.com/p/dart/source/detail?r=44238

Patch Set 1 #

Patch Set 2 : Fix long line #

Created: 5 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+32 lines, -15 lines)			Patch
	M	pkg/compiler/lib/src/cps_ir/cps_ir_builder.dart	View	1	2 chunks	+22 lines, -9 lines	0 comments	Download
	M	pkg/compiler/lib/src/cps_ir/cps_ir_builder_visitor.dart	View		4 chunks	+10 lines, -6 lines	0 comments	Download

Messages

Total messages: 4 (1 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

asgerf

5 years, 9 months ago (2015-03-04 14:42:56 UTC) #4

Message was sent while issue was closed.

Committed patchset #2 (id:20001) manually as 44238 (presubmit successful).

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages