Fix more async machinery (issue 22579 and possibly more to be triaged).

Fix more async machinery (issue 22579 and possibly more to be triaged).
Add regression test.

R=hausner@google.com

Committed: https://code.google.com/p/dart/source/detail?r=44250

[regis, 2015-03-04 23:54:07]

regis@google.com changed reviewers:
+ hausner@google.com

[regis, 2015-03-04 23:54:08]

I also renamed TryBlocks, which was confusing to use.

[hausner, 2015-03-05 00:23:01]

lgtm

https://codereview.chromium.org/977243002/diff/1/runtime/vm/parser.cc
File runtime/vm/parser.cc (right):

https://codereview.chromium.org/977243002/diff/1/runtime/vm/parser.cc#newcode...
runtime/vm/parser.cc:6076: TryStack* outer_try = PopTry();
I always get confused with this name. Try statements are popped from inside out
(innermost try is at the top of the stack). Thus, naming the try statement you
pop off the stack the "outer_try" makes my head spin. I prefer just
"try_statement" or something. In CloseAsyncTryBlock it's called "inner_try",
btw.

[regis, 2015-03-05 00:41:52]

Thanks!

https://codereview.chromium.org/977243002/diff/1/runtime/vm/parser.cc
File runtime/vm/parser.cc (right):

https://codereview.chromium.org/977243002/diff/1/runtime/vm/parser.cc#newcode...
runtime/vm/parser.cc:6076: TryStack* outer_try = PopTry();
On 2015/03/05 00:23:01, hausner wrote:
> I always get confused with this name. Try statements are popped from inside
out
> (innermost try is at the top of the stack). Thus, naming the try statement you
> pop off the stack the "outer_try" makes my head spin. I prefer just
> "try_statement" or something. In CloseAsyncTryBlock it's called "inner_try",
> btw. 

Done. Renamed to "try_statement" here and below.

[regis, 2015-03-05 00:42:40]

Committed patchset #2 (id:20001) manually as r44250 (presubmit successful).