Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(440)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 977053003: Copy the parameters to a sync* function for each invocation of .iterator (Closed)

Created:
5 years, 9 months ago by sigurdm
Modified:
5 years, 9 months ago
Reviewers:
floitsch
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Copy the parameters to a sync* function for each invocation of .iterator BUG= R=floitsch@google.com Committed: https://code.google.com/p/dart/source/detail?r=44227

Patch Set 1 : #

Total comments: 2

Patch Set 2 : Add TODO #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+24 lines, -4 lines) Patch
M pkg/compiler/lib/src/js/rewrite_async.dart View 1 2 chunks +24 lines, -3 lines 2 comments Download
M tests/language/language_dart2js.status View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 8 (2 generated)
sigurdm
5 years, 9 months ago (2015-03-04 12:58:32 UTC) #3
floitsch
LGTM. https://codereview.chromium.org/977053003/diff/20001/pkg/compiler/lib/src/js/rewrite_async.dart File pkg/compiler/lib/src/js/rewrite_async.dart (right): https://codereview.chromium.org/977053003/diff/20001/pkg/compiler/lib/src/js/rewrite_async.dart#newcode1789 pkg/compiler/lib/src/js/rewrite_async.dart:1789: js.VariableDeclarationList copyParameters = Add a TODO that you ...
5 years, 9 months ago (2015-03-04 13:03:03 UTC) #4
sigurdm
https://codereview.chromium.org/977053003/diff/20001/pkg/compiler/lib/src/js/rewrite_async.dart File pkg/compiler/lib/src/js/rewrite_async.dart (right): https://codereview.chromium.org/977053003/diff/20001/pkg/compiler/lib/src/js/rewrite_async.dart#newcode1789 pkg/compiler/lib/src/js/rewrite_async.dart:1789: js.VariableDeclarationList copyParameters = On 2015/03/04 13:03:02, floitsch wrote: > ...
5 years, 9 months ago (2015-03-04 13:05:47 UTC) #5
sigurdm
Committed patchset #2 (id:40001) manually as 44227 (presubmit successful).
5 years, 9 months ago (2015-03-04 13:09:32 UTC) #6
floitsch
https://codereview.chromium.org/977053003/diff/40001/pkg/compiler/lib/src/js/rewrite_async.dart File pkg/compiler/lib/src/js/rewrite_async.dart (right): https://codereview.chromium.org/977053003/diff/40001/pkg/compiler/lib/src/js/rewrite_async.dart#newcode1778 pkg/compiler/lib/src/js/rewrite_async.dart:1778: // TODO(sigurdm): We only need to do this copying ...
5 years, 9 months ago (2015-03-04 13:28:45 UTC) #7
sigurdm
5 years, 9 months ago (2015-03-04 13:37:52 UTC) #8
Message was sent while issue was closed. 
https://codereview.chromium.org/977053003/diff/40001/pkg/compiler/lib/src/js/...
File pkg/compiler/lib/src/js/rewrite_async.dart (right):

https://codereview.chromium.org/977053003/diff/40001/pkg/compiler/lib/src/js/...
pkg/compiler/lib/src/js/rewrite_async.dart:1778: // TODO(sigurdm): We only need
to do this copying for parameters that are mutated.
On 2015/03/04 13:28:45, floitsch wrote:
> Long line.

Somehow my editor lost the line showing me 80 chars when I updated today.
I'll fix it in the next CL touching this file.

Powered by Google App Engine
This is Rietveld 408576698