Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(134)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 975213002: Add tests for timers in background isolates in Dartium. (Closed)

Created:
5 years, 9 months ago by Alan Knight
Modified:
5 years, 9 months ago
Reviewers:
terry
CC:
reviews_dartlang.org
Target Ref:
refs/remotes/git-svn
Visibility:
Public.

Description

Add tests for timers in background isolates in Dartium. BUG= R=terry@google.com Committed: https://code.google.com/p/dart/source/detail?r=44241

Patch Set 1 #

Total comments: 3

Patch Set 2 : Review fixes #

Unified diffs Side-by-side diffs Delta from patch set Stats (+116 lines, -60 lines) Patch
A tests/html/async_cancellingisolate.dart View 1 1 chunk +31 lines, -0 lines 0 comments Download
A tests/html/async_oneshot.dart View 1 chunk +11 lines, -0 lines 0 comments Download
A tests/html/async_periodictimer.dart View 1 1 chunk +24 lines, -0 lines 0 comments Download
A tests/html/async_spawnuri_test.dart View 1 chunk +37 lines, -0 lines 0 comments Download
M tests/html/async_test.dart View 1 chunk +13 lines, -60 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
Alan Knight
5 years, 9 months ago (2015-03-03 23:44:51 UTC) #2
terry
minor nits - lgtm https://codereview.chromium.org/975213002/diff/1/tests/html/async_cancellingisolate.dart File tests/html/async_cancellingisolate.dart (right): https://codereview.chromium.org/975213002/diff/1/tests/html/async_cancellingisolate.dart#newcode7 tests/html/async_cancellingisolate.dart:7: var command = message[0]; Should ...
5 years, 9 months ago (2015-03-04 15:26:48 UTC) #3
Alan Knight
5 years, 9 months ago (2015-03-04 17:31:28 UTC) #4
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) manually as 44241 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698