Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(132)

Issue 974873004: fix deferred_multi_app test and change test status to reflect dartium fix (Closed)

Created:
5 years, 9 months ago by Jacob
Modified:
5 years, 9 months ago
Reviewers:
vsm, Bill Hesse
CC:
reviews_dartlang.org
Target Ref:
refs/remotes/git-svn
Visibility:
Public.

Description

fix deferred_multi_app test and change test status to reflect dartium fix BUG= R=vsm@google.com Committed: https://code.google.com/p/dart/source/detail?r=44240

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -5 lines) Patch
M tests/html/deferred_multi_app_htmltest.html View 1 chunk +1 line, -1 line 2 comments Download
M tests/html/html.status View 2 chunks +0 lines, -4 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
Jacob
Update tests to reflect fixing 16603 https://codereview.chromium.org/974873004/diff/1/tests/html/deferred_multi_app_htmltest.html File tests/html/deferred_multi_app_htmltest.html (right): https://codereview.chromium.org/974873004/diff/1/tests/html/deferred_multi_app_htmltest.html#newcode11 tests/html/deferred_multi_app_htmltest.html:11: "scripts": ["deferred_multi_app.dart", "deferred_multi_app_lib.dart"], ...
5 years, 9 months ago (2015-03-03 17:47:00 UTC) #2
vsm
lgtm
5 years, 9 months ago (2015-03-03 21:33:01 UTC) #3
Jacob
Committed patchset #1 (id:1) manually as 44240 (presubmit successful).
5 years, 9 months ago (2015-03-04 17:27:15 UTC) #4
Bill Hesse
5 years, 9 months ago (2015-03-05 10:13:29 UTC) #6
Message was sent while issue was closed.
https://codereview.chromium.org/974873004/diff/1/tests/html/deferred_multi_ap...
File tests/html/deferred_multi_app_htmltest.html (right):

https://codereview.chromium.org/974873004/diff/1/tests/html/deferred_multi_ap...
tests/html/deferred_multi_app_htmltest.html:11: "scripts":
["deferred_multi_app.dart", "deferred_multi_app_lib.dart"],
On 2015/03/03 17:47:00, Jacob wrote:
> it was a bug that deferred_multi_app_lib.dart wasn't listed.

With dart2js and dart2dart, the lib is compiled into the output file, and does
not need to be compiled separately.  This is why it was working on dart2js
browser tests.  For compiler == 'none' tests, we will need to copy this to the
output directory.  So we will need to distinguish between scripts, with a main()
function, that will be run on the page, and library files that just need copied
if there is no compilation stage.  It should be safe to add this, but dart2js
will just fail, or do nothing, or produce bogus output, I think.  It doesn't
look like it's failing.

Powered by Google App Engine
This is Rietveld 408576698