Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(312)

Issue 973913002: Treat functions generated for closurization as equivalent to their source functions. (Closed)

Created:
5 years, 9 months ago by rmacnak
Modified:
5 years, 9 months ago
Reviewers:
gbracha, siva
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Target Ref:
refs/remotes/git-svn
Visibility:
Public.

Description

Treat functions generated for closurization as equivalent to their source functions. BUG=http://dartbug.com/22601 R=asiva@google.com, gbracha@google.com Committed: https://code.google.com/p/dart/source/detail?r=44674

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+35 lines, -0 lines) Patch
M runtime/lib/mirrors.cc View 1 1 chunk +7 lines, -0 lines 0 comments Download
M tests/lib/lib.status View 1 1 chunk +1 line, -0 lines 0 comments Download
A tests/lib/mirrors/closurization_equivalence_test.dart View 1 chunk +27 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
rmacnak
5 years, 9 months ago (2015-03-03 20:47:19 UTC) #2
gbracha
lgtm
5 years, 9 months ago (2015-03-03 22:59:20 UTC) #3
siva
lgtm
5 years, 9 months ago (2015-03-24 19:43:48 UTC) #4
rmacnak
5 years, 9 months ago (2015-03-24 20:06:49 UTC) #5
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as 44674 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698