Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(113)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 973843005: Fix VM bug with super-constructor invocation and mixins. (Closed)

Created:
5 years, 9 months ago by Florian Schneider
Modified:
5 years, 9 months ago
Reviewers:
hausner
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Visibility:
Public.

Description

Fix VM bug with super-constructor invocation and mixins. When using mixins, the constructor of a super-class was incorrectly invoked twice if the super() call was not at the end of the initializer list. When generating the super constructor call in an implicit constructor, pass along the phase parameter that comes in instead of invoking all phases. BUG=dartbug.com/22604 TEST=tests/language/constructor_with_mixin_test.dart R=hausner@google.com Committed: https://code.google.com/p/dart/source/detail?r=44242

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+47 lines, -8 lines) Patch
M runtime/vm/parser.h View 1 chunk +1 line, -0 lines 0 comments Download
M runtime/vm/parser.cc View 4 chunks +11 lines, -8 lines 0 comments Download
A tests/language/constructor_with_mixin_test.dart View 1 chunk +35 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
Florian Schneider
5 years, 9 months ago (2015-03-04 12:55:45 UTC) #2
hausner
Very nice, thank you. LGTM.
5 years, 9 months ago (2015-03-04 17:57:11 UTC) #3
Florian Schneider
5 years, 9 months ago (2015-03-04 18:02:47 UTC) #4
Message was sent while issue was closed. 
Committed patchset #1 (id:1) manually as r44242 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698