Issue 973553005: Fix memory leak in CPU Profile page

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 973553005: Fix memory leak in CPU Profile page (Closed)

Created:
5 years, 9 months ago by Cutch

Modified:
5 years, 9 months ago

Reviewers:
rmacnak

CC:
reviews_dartlang.org, turnidge, vm-dev_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Target Ref:
refs/remotes/git-svn

Visibility:
Public.

More Reviews

Description

Fix memory leak in CPU Profile page - Programmatically clear all onClick listeners. - Use an iterative call tree loader. - Load call trees on demand. - When a sample was filled before exhausting the call stack, mark that the sample's call stack is truncated. - Insert '[Truncated]' tag nodes into call trees. R=rmacnak@google.com Committed: https://code.google.com/p/dart/source/detail?r=44190

Patch Set 1 #

Patch Set 2 : #

Created: 5 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+371 lines, -145 lines)			Patch
M	runtime/observatory/lib/cpu_profile.dart	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	runtime/observatory/lib/src/app/view_model.dart	View		5 chunks	+15 lines, -2 lines	0 comments	Download
M	runtime/observatory/lib/src/cpu_profile/cpu_profile.dart	View		7 chunks	+152 lines, -80 lines	0 comments	Download
M	runtime/observatory/lib/src/elements/cpu_profile.dart	View	1	6 chunks	+26 lines, -18 lines	0 comments	Download
M	runtime/observatory/lib/src/elements/cpu_profile.html	View	1	2 chunks	+2 lines, -2 lines	0 comments	Download
M	runtime/vm/profiler.h	View		3 chunks	+11 lines, -0 lines	0 comments	Download
M	runtime/vm/profiler.cc	View		7 chunks	+17 lines, -5 lines	0 comments	Download
M	runtime/vm/profiler_service.cc	View		18 chunks	+142 lines, -37 lines	0 comments	Download
M	runtime/vm/tags.h	View		1 chunk	+3 lines, -0 lines	0 comments	Download
M	runtime/vm/tags.cc	View		1 chunk	+2 lines, -1 line	0 comments	Download

Messages

Total messages: 4 (1 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

Cutch

5 years, 9 months ago (2015-03-03 19:00:37 UTC) #4

Message was sent while issue was closed.

Committed patchset #2 (id:2) manually as 44190 (presubmit successful).

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages