Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(353)

Issue 973193003: Changed Dartium expiration to 52 weeks (Closed)

Created:
5 years, 9 months ago by terry
Modified:
5 years, 9 months ago
Reviewers:
vsm, siva
CC:
reviews_dartlang.org
Target Ref:
refs/remotes/git-svn
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 2

Patch Set 2 : More accurate +1 year #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M tools/dartium/generate_dart_vm_version.py View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 8 (1 generated)
terry
5 years, 9 months ago (2015-03-03 23:04:24 UTC) #2
siva
lgtm
5 years, 9 months ago (2015-03-03 23:12:47 UTC) #3
vsm
lgtm https://codereview.chromium.org/973193003/diff/1/tools/dartium/generate_dart_vm_version.py File tools/dartium/generate_dart_vm_version.py (right): https://codereview.chromium.org/973193003/diff/1/tools/dartium/generate_dart_vm_version.py#newcode30 tools/dartium/generate_dart_vm_version.py:30: expiration_date = datetime.date.today() + datetime.timedelta(weeks=52) you could also ...
5 years, 9 months ago (2015-03-03 23:19:54 UTC) #4
terry
https://codereview.chromium.org/973193003/diff/1/tools/dartium/generate_dart_vm_version.py File tools/dartium/generate_dart_vm_version.py (right): https://codereview.chromium.org/973193003/diff/1/tools/dartium/generate_dart_vm_version.py#newcode30 tools/dartium/generate_dart_vm_version.py:30: expiration_date = datetime.date.today() + datetime.timedelta(weeks=52) On 2015/03/03 23:19:54, vsm ...
5 years, 9 months ago (2015-03-04 02:24:44 UTC) #5
terry
Committed patchset #2 (id:20001) manually as 44218 (presubmit successful).
5 years, 9 months ago (2015-03-04 02:26:07 UTC) #6
vsm
On 2015/03/04 02:24:44, terry wrote: > https://codereview.chromium.org/973193003/diff/1/tools/dartium/generate_dart_vm_version.py > File tools/dartium/generate_dart_vm_version.py (right): > > https://codereview.chromium.org/973193003/diff/1/tools/dartium/generate_dart_vm_version.py#newcode30 > ...
5 years, 9 months ago (2015-03-04 02:26:23 UTC) #7
ricow1
5 years, 9 months ago (2015-03-05 08:09:02 UTC) #8
Message was sent while issue was closed.
On 2015/03/04 02:26:23, vsm wrote:
> On 2015/03/04 02:24:44, terry wrote:
> >
>
https://codereview.chromium.org/973193003/diff/1/tools/dartium/generate_dart_...
> > File tools/dartium/generate_dart_vm_version.py (right):
> > 
> >
>
https://codereview.chromium.org/973193003/diff/1/tools/dartium/generate_dart_...
> > tools/dartium/generate_dart_vm_version.py:30: expiration_date =
> > datetime.date.today() + datetime.timedelta(weeks=52)
> > On 2015/03/03 23:19:54, vsm wrote:
> > > you could also do datetime.timedelta(days=365)
> > 
> > Yeah that's more accurate than 52 weeks, not precise but closer to a year
> > (365.2425 days for a Gregorian year).
> > 
> > Done.
> 
> You could do milliseconds too, but that might be overkill.  :-)
> 
> lgtm

Why not just remove this entirely?

Powered by Google App Engine
This is Rietveld 408576698