Issue 973103002: One more fix to async machinery (rethrow in finally, issue 22595).

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 973103002: One more fix to async machinery (rethrow in finally, issue 22595). (Closed)

Created:
5 years, 9 months ago by regis

Modified:
5 years, 9 months ago

Reviewers:
hausner

CC:
reviews_dartlang.org, vm-dev_dartlang.org, Ivan Posva

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

One more fix to async machinery (rethrow in finally, issue 22595). R=hausner@google.com Committed: https://code.google.com/p/dart/source/detail?r=44189

Created: 5 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+110 lines, -77 lines)			Patch
M	runtime/vm/ast.h	View	1	4 chunks	+12 lines, -0 lines	0 comments	Download
M	runtime/vm/flow_graph_builder.cc	View	1	1 chunk	+2 lines, -3 lines	0 comments	Download
M	runtime/vm/parser.h	View	1	1 chunk	+5 lines, -2 lines	0 comments	Download
M	runtime/vm/parser.cc	View	1	20 chunks	+91 lines, -70 lines	0 comments	Download
M	tests/language/language.status	View	1	1 chunk	+0 lines, -2 lines	0 comments	Download

Total messages: 5 (1 generated)

hausner

LGTM. You'll have to add this to the async* code that I just checked in.

5 years, 9 months ago (2015-03-03 18:15:06 UTC) #3

regis

5 years, 9 months ago (2015-03-03 18:34:25 UTC) #5

Message was sent while issue was closed.

Committed patchset #2 (id:20001) manually as r44189 (presubmit successful).